Merge ~bryce/ubuntu/+source/virglrenderer:merge-v1.0.0-1-noble into ubuntu/+source/virglrenderer:debian/sid

Proposed by Bryce Harrington
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: git-ubuntu bot
Merged at revision: 1fd46178a30c78bbb865d5a7ecbb26b390c52a07
Proposed branch: ~bryce/ubuntu/+source/virglrenderer:merge-v1.0.0-1-noble
Merge into: ubuntu/+source/virglrenderer:debian/sid
Diff against target: 130 lines (+72/-2)
3 files modified
debian/changelog (+62/-0)
debian/control (+2/-1)
debian/rules (+8/-1)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Andreas Hasenack Approve
Canonical Server Pending
Canonical Server Reporter Pending
Canonical Server packageset reviewers Pending
Review via email: mp+456150@code.launchpad.net

Description of the change

Just one bit of delta remaining, which still must be included. It's been forwarded to Debian but still not taken by them yet:
  https://salsa.debian.org/debian/virglrenderer/-/merge_requests/5

PPA: https://launchpad.net/~bryce/+archive/ubuntu/virglrenderer-merge-v1.0.0-1

No autopkgtests for this package but the PPA shows it builds ok.

To post a comment you must log in.
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

range-diff ok
git range-diff bryce/old/debian..bryce/logical/0.10.4-1ubuntu1 bryce/new/debian..bryce/merge-v1.0.0-1-noble

single delta preserved ok

Debian changes:
only new symbols -> reverse deps? soname was kept. Does qemu need rebuild? Looks like not. I installed qemu-system-gui and ran a quick check, the binaries seem to startup fine without symbols errors. qemu doesn't take so long to rebuild, but I won't request a rebuild test for a devel release.

-Dvenus switched to true, was experimental before, and it was enabled already anyway.

GALLIUM_DRIVER changed from softpipe to llvmpipe. Debian changelog says it's for testing. I don't know what it is, and therefore can't suggest if it's a good or bad move. But since noble is an LTS, we should keep an eye on this.

Release notes for 1.0.0: https://gitlab.freedesktop.org/virgl/virglrenderer/-/releases/1.0.0 look ok.

+1

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: bryce, ahasenack
Uploaders: bryce, ahasenack
MP auto-approved

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for the review; uploaded:

 fixup_buildinfo ../virglrenderer_1.0.0-1ubuntu1.dsc ../virglrenderer_1.0.0-1ubuntu1_source.buildinfo
 signfile buildinfo ../virglrenderer_1.0.0-1ubuntu1_source.buildinfo A661100B3DAC1D4F2CAD8A54E603B2578FB8F0FB

 fixup_changes dsc ../virglrenderer_1.0.0-1ubuntu1.dsc ../virglrenderer_1.0.0-1ubuntu1_source.changes
 fixup_changes buildinfo ../virglrenderer_1.0.0-1ubuntu1_source.buildinfo ../virglrenderer_1.0.0-1ubuntu1_source.changes
 signfile changes ../virglrenderer_1.0.0-1ubuntu1_source.changes A661100B3DAC1D4F2CAD8A54E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading virglrenderer_1.0.0-1ubuntu1.dsc: done.
  Uploading virglrenderer_1.0.0.orig.tar.bz2: done.
  Uploading virglrenderer_1.0.0-1ubuntu1.debian.tar.xz: done.
  Uploading virglrenderer_1.0.0-1ubuntu1_source.buildinfo: done.
  Uploading virglrenderer_1.0.0-1ubuntu1_source.changes: done.
Successfully uploaded packages.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index a9d1e19..2ec9982 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,11 @@
6+virglrenderer (1.0.0-1ubuntu1) noble; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #2040435). Remaining changes:
9+ - d/rules: Disable video acceleration on Ubuntu until libva gets
10+ repromoted
11+
12+ -- Bryce Harrington <bryce@canonical.com> Wed, 22 Nov 2023 18:15:12 -0800
13+
14 virglrenderer (1.0.0-1) unstable; urgency=medium
15
16 * New upstream version 1.0.0
17@@ -7,6 +15,27 @@ virglrenderer (1.0.0-1) unstable; urgency=medium
18
19 -- Gert Wollny <gewo@debian.org> Sat, 14 Oct 2023 20:28:16 +0200
20
21+virglrenderer (0.10.4-1ubuntu1) lunar; urgency=medium
22+
23+ * Merge with Debian unstable (LP: #1993453).
24+ * Added changes:
25+ - d/rules: Disable video acceleration on Ubuntu until libva gets repromoted.
26+ * Dropped:
27+ - d/p/lp-1950941*: fix out of bounds check
28+ (LP #1950941)
29+ [Fixed in upstream release 0.10.0]
30+ - out-of-bounds write in read_transfer_data()
31+ + d/p/CVE-2022-0135.patch: Add test to resource OOB write
32+ and fix it in src/vrend_renderer.c, tests/test_fuzzer_formats.c.
33+ [Fixed in upstream release 0.10.0]
34+ - info leak in vrend_resource_alloc_buffer()
35+ + d/p/CVE-2022-0175.patch: clear memory when allocating a
36+ host-backed memory resource in src/vrend_renderer.c,
37+ tests/test_virgl_transfer.c.
38+ [Fixed in upstream release 0.10.0]
39+
40+ -- Bryce Harrington <bryce@canonical.com> Thu, 05 Jan 2023 06:49:25 -0800
41+
42 virglrenderer (0.10.4-1) unstable; urgency=medium
43
44 * New upstream version 0.10.4
45@@ -63,6 +92,27 @@ virglrenderer (0.10.0-1) unstable; urgency=medium
46 * Enable video backend and add dependency accordingly
47 -- Gert Wollny <gewo@debian.org> Fri, 02 Sep 2022 17:36:05 +0200
48
49+virglrenderer (0.9.1-1~exp1ubuntu2) jammy; urgency=medium
50+
51+ * SECURITY UPDATE: out-of-bounds write in read_transfer_data()
52+ - debian/patches/CVE-2022-0135.patch: Add test to resource OOB write
53+ and fix it in src/vrend_renderer.c, tests/test_fuzzer_formats.c.
54+ - CVE-2022-0135
55+ * SECURITY UPDATE: info leak in vrend_resource_alloc_buffer()
56+ - debian/patches/CVE-2022-0175.patch: clear memory when allocating a
57+ host-backed memory resource in src/vrend_renderer.c,
58+ tests/test_virgl_transfer.c.
59+ - CVE-2022-0175
60+
61+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Mon, 28 Feb 2022 14:19:07 -0500
62+
63+virglrenderer (0.9.1-1~exp1ubuntu1) jammy; urgency=medium
64+
65+ * Merge with Debian unstable (LP: #1959175). Remaining changes:
66+ - d/p/lp-1950941*: fix out of bounds check (LP #1950941)
67+
68+ -- Utkarsh Gupta <utkarsh@ubuntu.com> Fri, 25 Feb 2022 02:23:43 +0530
69+
70 virglrenderer (0.9.1-1~exp1) experimental; urgency=medium
71
72 * New upstream version 0.9.1
73@@ -76,6 +126,18 @@ virglrenderer (0.9.0-1~exp1) experimental; urgency=medium
74
75 -- Gert Wollny <gewo@debian.org> Tue, 06 Apr 2021 15:24:55 +0200
76
77+virglrenderer (0.8.2-5ubuntu1) jammy; urgency=medium
78+
79+ * d/p/lp-1950941*: fix out of bounds check (LP: #1950941)
80+
81+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Thu, 02 Dec 2021 08:34:48 +0100
82+
83+virglrenderer (0.8.2-5build1) impish; urgency=medium
84+
85+ * No-change rebuild to build packages with zstd compression.
86+
87+ -- Matthias Klose <doko@ubuntu.com> Thu, 07 Oct 2021 12:26:08 +0200
88+
89 virglrenderer (0.8.2-5) unstable; urgency=medium
90
91 [ Christian Ehrhardt ]
92diff --git a/debian/control b/debian/control
93index dc591e6..e7b4a0e 100644
94--- a/debian/control
95+++ b/debian/control
96@@ -1,7 +1,8 @@
97 Source: virglrenderer
98 Section: libs
99 Priority: optional
100-Maintainer: Gert Wollny <gewo@debian.org>
101+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
102+XSBC-Original-Maintainer: Gert Wollny <gewo@debian.org>
103 Build-Depends: check,
104 debhelper-compat (= 13),
105 libdrm-dev,
106diff --git a/debian/rules b/debian/rules
107index 6ff1f63..1868777 100755
108--- a/debian/rules
109+++ b/debian/rules
110@@ -4,12 +4,19 @@ include /usr/share/dpkg/buildflags.mk
111 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
112 export CK_TIMEOUT_MULTIPLIER=100
113
114+# libva is not currently in Ubuntu main
115+ifeq ($(shell dpkg-vendor --query vendor),Ubuntu)
116+VIDEO := -Dvideo=false
117+else
118+VIDEO := -Dvideo=true
119+endif
120+
121 %:
122 dh $@ --buildsystem=meson
123
124 configure-opts = \
125 -Dtests=true \
126- -Dvideo=true \
127+ $(VIDEO) \
128
129 ifneq (armel, ${DEB_HOST_ARCH})
130 # vulkan requires 32bit atomic ints, armel lacks one (#1021861)

Subscribers

People subscribed via source and target branches