Ubuntu
augeas package

Code review comment for ~bryce/ubuntu/+source/augeas:ubuntu/xenial-updates

  1. Git
  2. lp:~bryce/ubuntu/+source/augeas
  3. ubuntu/xenial-updates
  4. Merge into ubuntu/devel
Revision history for this message
Bryce Harrington (bryce) wrote :

On Tue, Jun 30, 2020 at 09:12:16AM -0000, Christian Ehrhardt  wrote:
> Review: Approve
>
> The changes LGTM and I agreed that the regression risk seems low.
> Patch is upstream and in later version and all else that is usually needed.
>
> It seems the bug was dead by a lack of feedback or a local reproducer. Since you got the latter we are good.
>
> +1 for resolving this.
>
> P.S. you will get bonus points if you can tell me at standup why "patch on a plate" by Jon is different than "general Community patch on a plate" :-)

As he's a community member, I would think they're in the same bucket, I
didn't mean to imply it was anything different than that. Although in
this case he deserves props for taking the extra step into the SRU prep
work, it's too bad it didn't get the necessary attention at the time.

Bryce

« Back to merge proposal