Merge ~bryce/ubuntu/+source/augeas:ubuntu/xenial-updates into ubuntu/+source/augeas:ubuntu/devel

[Bryce Harrington]

This is a patch on a plate - Jon Grimm got the fix pretty much ready to go but didn't finish the SRU. I've reproduced the original issue and verified the fix from his PPA. The patch lacked DEP3 and had an incorrect version number, and the SRU paperwork needed filled in. I've taken care of all that and think this is ready to go.

I anticipate one counter-argument is that xenial is quite old now, however note that the userbase for this type of issue (puppet, php) are also the audience for ESM so I could imagine this bug could still be a problem even once xenial is out of support. The fix is quite trivial and has very little regression risk.

[Christian Ehrhardt  (paelzer)]

The changes LGTM and I agreed that the regression risk seems low.
Patch is upstream and in later version and all else that is usually needed.

It seems the bug was dead by a lack of feedback or a local reproducer. Since you got the latter we are good.

+1 for resolving this.

P.S. you will get bonus points if you can tell me at standup why "patch on a plate" by Jon is different than "general Community patch on a plate" :-)

review: Approve

[Bryce Harrington (bryce)]

On Tue, Jun 30, 2020 at 09:12:16AM -0000, Christian Ehrhardt  wrote:
> Review: Approve
>
> The changes LGTM and I agreed that the regression risk seems low.
> Patch is upstream and in later version and all else that is usually needed.
>
> It seems the bug was dead by a lack of feedback or a local reproducer. Since you got the latter we are good.
>
> +1 for resolving this.
>
> P.S. you will get bonus points if you can tell me at standup why "patch on a plate" by Jon is different than "general Community patch on a plate" :-)

As he's a community member, I would think they're in the same bucket, I
didn't mean to imply it was anything different than that. Although in
this case he deserves props for taking the extra step into the SRU prep
work, it's too bad it didn't get the necessary attention at the time.

Bryce

Unmerged commits

b138f64... by Bryce Harrington on 2020-06-30

changelog

991b4e3... by Bryce Harrington on 2020-06-30

  [ Jon Grimm ]
  * Fix location of php.ini for PHP 7 (LP: #1580731):
    - d/p/0004-Reflect-Ubuntu-16.04-location-of-php.ini-399.patch

689056f... by Leonidas S. Barbosa on 2017-08-18

1.4.0-0ubuntu1.1 (patches unapplied)

Imported using git-ubuntu import.

b73ca8d... by Raphaël Pinson on 2015-12-17

1.4.0-0ubuntu1 (patches unapplied)

Imported using git-ubuntu import.

43fb7ce... by Robie Basak on 2015-10-27

1.3.0-0ubuntu2 (patches unapplied)

Imported using git-ubuntu import.

3d7521d... by Raphaël Pinson on 2014-12-01

1.3.0-0ubuntu1 (patches unapplied)

Imported using git-ubuntu import.