Code review comment for ~bryce/ubuntu/+source/augeas:ubuntu/xenial-updates

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

The changes LGTM and I agreed that the regression risk seems low.
Patch is upstream and in later version and all else that is usually needed.

It seems the bug was dead by a lack of feedback or a local reproducer. Since you got the latter we are good.

+1 for resolving this.

P.S. you will get bonus points if you can tell me at standup why "patch on a plate" by Jon is different than "general Community patch on a plate" :-)

review: Approve

« Back to merge proposal