Code review comment for ppa-dev-tools:fix-all-proposed-triggers

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

LGTM. Thanks, Bryce :)

It seems this branch needs to be rebased on the main branch though (I reviewed and tested these changes after a local rebase).

I no longer se duplicated entries. Instead, I see the all-proposed URLs as intended.

And thanks for writing all those tests.

I am also seeing some issues (unrelated to the changes proposed here):

- The UTF-8 characters seem to be broken here (I am on noble). I could find no good past version of the package in the development history, so I suppose this is due to some new/inconsistent package in my system. Once it is safe to pull the latest noble changes in, I will test again and report issues as needed.
- I see 4 failing tests when running the test suite. I am unsure if this is related to the bullet point above, but git-bisect shows me that 5d7cbc9 is the first "bad" revision here. I suppose they are due to the "file:///home/bryce/src/PpaDevTools/" hardcoded entries in the test suite.
- Finally, lately I have been seeing error messages when running the `tests` sub-command. These does not seem to affect the subcommand usability, but the error messages are always present. They look like this:

Error: Could not retrieve data from https://autopkgtest.ubuntu.com/results/autopkgtest-focal-athos-ribeiro-phpmyadmin-php83/?format=plain: HTTP Error 404: Not FoundError: Could not retrieve data from https://autopkgtest.ubuntu.com/results/autopkgtest-jammy-athos-ribeiro-phpmyadmin-php83/?format=plain: HTTP Error 404: Not FoundError: Could not retrieve data from https://autopkgtest.ubuntu.com/results/autopkgtest-mantic-athos-ribeiro-phpmyadmin-php83/?format=plain: HTTP Error 404: Not FoundError: Could not retrieve data from https://autopkgtest.ubuntu.com/results/autopkgtest-trusty-athos-ribeiro-phpmyadmin-php83/?format=plain: HTTP Error 404: Not FoundError: Could not retrieve data from https://autopkgtest.ubuntu.com/results/autopkgtest-xenial-athos-ribeiro-phpmyadmin-php83/?format=plain: HTTP Error 404: Not FoundError: Could not retrieve data from https://autopkgtest.ubuntu.com/results/autopkgtest-bionic-athos-ribeiro-phpmyadmin-php83/?f

review: Approve

« Back to merge proposal