Merge ppa-dev-tools:fix-all-proposed-triggers into ppa-dev-tools:main
Status: | Merged | ||||
---|---|---|---|---|---|
Merge reported by: | Bryce Harrington | ||||
Merged at revision: | cc47e76902f940fa9a2b1dcaa97795df9390d96c | ||||
Proposed branch: | ppa-dev-tools:fix-all-proposed-triggers | ||||
Merge into: | ppa-dev-tools:main | ||||
Diff against target: |
278 lines (+127/-28) 4 files modified
ppa/trigger.py (+2/-2) scripts/ppa (+6/-5) tests/test_result.py (+90/-4) tests/test_trigger.py (+29/-17) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Athos Ribeiro (community) | Approve | ||
PpaDevTools Developers | Pending | ||
Canonical Server Reporter | Pending | ||
Review via email: mp+463178@code.launchpad.net |
Description of the change
The fix for LP: #2044608 is quite simple, however test coverage of the code in question was missing. This branch provides those tests both for the trigger-related functionality in the Results class, and for the Trigger class itself.
Additionally, this includes a fix for a recent regression in a branch that improved exit codes. A standard python exit code documented in the os module turns out to be platform-specific, and Linux is not one of those platforms... Without this fix, the command line examples will fail.
Anyway, testing is as usual:
$ make check
or:
$ pytest-3
To verify the CLI operation live, I ran against seb's PPA:
$ ./scripts/ppa tests -L ppa:seb128/
Try it with and without -L, and with and without --show-rdepends. It should show the line for the all-proposed links in all cases.
LGTM. Thanks, Bryce :)
It seems this branch needs to be rebased on the main branch though (I reviewed and tested these changes after a local rebase).
I no longer se duplicated entries. Instead, I see the all-proposed URLs as intended.
And thanks for writing all those tests.
I am also seeing some issues (unrelated to the changes proposed here):
- The UTF-8 characters seem to be broken here (I am on noble). I could find no good past version of the package in the development history, so I suppose this is due to some new/inconsistent package in my system. Once it is safe to pull the latest noble changes in, I will test again and report issues as needed. //home/ bryce/src/ PpaDevTools/ " hardcoded entries in the test suite.
- I see 4 failing tests when running the test suite. I am unsure if this is related to the bullet point above, but git-bisect shows me that 5d7cbc9 is the first "bad" revision here. I suppose they are due to the "file:/
- Finally, lately I have been seeing error messages when running the `tests` sub-command. These does not seem to affect the subcommand usability, but the error messages are always present. They look like this:
Error: Could not retrieve data from https:/ /autopkgtest. ubuntu. com/results/ autopkgtest- focal-athos- ribeiro- phpmyadmin- php83/? format= plain: HTTP Error 404: Not FoundError: Could not retrieve data from https:/ /autopkgtest. ubuntu. com/results/ autopkgtest- jammy-athos- ribeiro- phpmyadmin- php83/? format= plain: HTTP Error 404: Not FoundError: Could not retrieve data from https:/ /autopkgtest. ubuntu. com/results/ autopkgtest- mantic- athos-ribeiro- phpmyadmin- php83/? format= plain: HTTP Error 404: Not FoundError: Could not retrieve data from https:/ /autopkgtest. ubuntu. com/results/ autopkgtest- trusty- athos-ribeiro- phpmyadmin- php83/? format= plain: HTTP Error 404: Not FoundError: Could not retrieve data from https:/ /autopkgtest. ubuntu. com/results/ autopkgtest- xenial- athos-ribeiro- phpmyadmin- php83/? format= plain: HTTP Error 404: Not FoundError: Could not retrieve data from https:/ /autopkgtest. ubuntu. com/results/ autopkgtest- bionic- athos-ribeiro- phpmyadmin- php83/? f