Merge ppa-dev-tools:fix-command-tests-with-releases into ppa-dev-tools:main

[Bryce Harrington]

Fix for issue Andreas raised today, that running ppa tests --releases jammy produces no results when it should.

The fix for this is straightforward, and I noticed the same pattern a couple other places and fix them up as well.

There are actually several other bugs reported with related issues around test output filtering. I thought of including fixes for those as well, however they involve some additional plumbing work (and associated unit tests) and a fair bit of refactoring, so am going to leave that work for later, to keep this branch focused more on bug fixing. The refactoring of command_tests() has been an ongoing project, and those fixes will come as that work gets completed.

I'd really like to include some unit test updates with this branch, however test_command_tests() only deals with triggers so far. I started looking at expanding that to also include results, however I think it will be better to work on tests once the aforementioned refactoring is done.

For testing this fix, I ran the command in various ways against different people's PPAs. The commit messages make mention of some of the more interesting ones I tested against.

[Andreas Hasenack (ahasenack)]

+1

Initially I thought unpack_to_dict() was quite a convoluted way to make a comma-separated string a list, but it's a function used in many places and it has tests.

review: Approve

[Bryce Harrington (bryce)]

Thanks for the review Andreas, branch landed:

$ git merge --ff-only fix-command-tests-with-releases
Updating 6c63268..06e6152
Fast-forward
 ppa/ppa.py | 6 +++---
 scripts/ppa | 13 ++++++++++++-
 2 files changed, 15 insertions(+), 4 deletions(-)
$ git push origin
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/ppa-dev-tools
   6c63268..06e6152 main -> main

diff --git a/ppa/ppa.py b/ppa/ppa.py
index 57ec14b..23ea58a 100755
--- a/ppa/ppa.py
+++ b/ppa/ppa.py
@@ -528,7 +528,7 @@ class Ppa:
             print("Successfully published all builds for all architectures")
         return retval
 
-    def get_autopkgtest_waiting(self, releases):
+    def get_autopkgtest_waiting(self, releases: list[str]):
         """Return iterator of queued autopkgtests for this PPA.
 
         See get_waiting() for details
@@ -542,7 +542,7 @@ class Ppa:
             return get_waiting(response, releases=releases, ppa=str(self))
         return []
 
-    def get_autopkgtest_running(self, releases):
+    def get_autopkgtest_running(self, releases: list[str]):
         """Return iterator of queued autopkgtests for this PPA.
 
         See get_running() for details
@@ -556,7 +556,7 @@ class Ppa:
             return get_running(response, releases=releases, ppa=str(self))
         return []
 
-    def get_autopkgtest_results(self, releases, architectures):
+    def get_autopkgtest_results(self, releases: list[str], architectures: list[str]):
         """Returns iterator of results from autopkgtest runs for this PPA.
 
         See get_results() for details
diff --git a/scripts/ppa b/scripts/ppa
index 9dbb15a..edf82b7 100755
--- a/scripts/ppa
+++ b/scripts/ppa
@@ -849,8 +849,17 @@ def command_tests(lp: Lp, config: dict[str, str]) -> int:
     if releases is None:
         udi = UbuntuDistroInfo()
         releases = udi.supported()
+    if isinstance(releases, str):
+        releases = list(unpack_to_dict(releases).keys())
+    if not isinstance(releases, list):
+        raise TypeError(f"Parameter releases={releases} not of type list")
 
     packages = config.get('packages', None)
+    if not packages is None:
+        if isinstance(packages, str):
+            packages = list(unpack_to_dict(packages).keys())
+        if not isinstance(packages, list):
+            raise TypeError(f"Parameter packages={packages} not of type list")
 
     the_ppa = get_ppa(lp, config)
     if not the_ppa.exists():
@@ -859,7 +868,9 @@ def command_tests(lp: Lp, config: dict[str, str]) -> int:
 
     architectures = config.get('architectures', ARCHES_AUTOPKGTEST)
     if isinstance(architectures, str):
-        architectures = unpack_to_dict(architectures).keys()
+        architectures = list(unpack_to_dict(architectures).keys())
+    if not isinstance(architectures, list):
+        raise TypeError(f"Parameter architectures={architectures} not of type list")
 
     try:
         # Triggers