1
diff --git a/NEWS.md b/NEWS.md
2
index f40bac0..32948bd 100644
3
--- a/NEWS.md
4
+++ b/NEWS.md
5
@@ -1,3 +1,19 @@
6
1
# Unreleased #
7
2
8
3
Reverse dependencies, build dependencies, and installation dependencies
9
4
can be identified for a given source package using cached APT
10
5
information.  This list of packages will be used to generate lists of
11
6
autopkgtest triggers, which when run should help identify issues that
12
7
could get flagged in Britney2 runs.  While similar to functionality
13
8
provided by Bileto+Britney2, it is a lighterweight facsimile which
14
9
doesn't handle special cases so should not be considered an equivalent,
15
10
just as a preliminary screen to catch basic issues.
16
11
17
12
The location of the cache can be set in a config file or via a cli
18
13
argument, but by default will store under the user's ~/.config/
19
14
directory.
20
15
21
16
22
1
# 0.3.0 Release #
17
# 0.3.0 Release #
23
2
18
24
3
Autopkgtest trigger action URLs are printed for packages in the PPA when
19
Autopkgtest trigger action URLs are printed for packages in the PPA when
25
diff --git a/ppa/constants.py b/ppa/constants.py
26
index 4270392..2d37539 100644
27
--- a/ppa/constants.py
28
+++ b/ppa/constants.py
29
@@ -19,3 +19,20 @@ ARCHES_AUTOPKGTEST = ["amd64", "arm64", "armhf", "i386", "ppc64el", "s390x"]
30
19
19
31
20
URL_LPAPI = "https://api.launchpad.net/devel"
20
URL_LPAPI = "https://api.launchpad.net/devel"
32
21
URL_AUTOPKGTEST = "https://autopkgtest.ubuntu.com"
21
URL_AUTOPKGTEST = "https://autopkgtest.ubuntu.com"
33
22
34
23
DISTRO_UBUNTU_COMPONENTS = ['main', 'restricted', 'universe', 'multiverse']
35
24
36
25
DISTRO_UBUNTU_POCKETS = ['release', 'security', 'proposed', 'updates', 'backports']
37
26
DISTRO_UBUNTU_POCKETS_UPDATES = ['release', 'security', 'updates']
38
27
39
28
LOCAL_REPOSITORY_PATH = "/tmp/ubuntu"
40
29
LOCAL_REPOSITORY_MIRRORING_DIRECTIONS = f"""
41
30
Tip: You can generate (and refresh) a dists-only mirror thusly:")
42
31
  $ mkdir {LOCAL_REPOSITORY_PATH}
43
32
  $ rsync -va \\
44
33
      --exclude={{'*/installer*','*/i18n/*','*/uefi/*','*/Contents*','*/by-hash/*','*tar.gz'}} \\
45
34
      rsync://archive.ubuntu.com/ubuntu/dists {LOCAL_REPOSITORY_PATH}
46
35
47
36
It's recommended to run the rsync command as a cronjob to keep your
48
37
repository up to date as often as desired.
49
38
"""
50
diff --git a/ppa/ppa.py b/ppa/ppa.py
51
index 1536b7d..aa4fd7c 100755
52
--- a/ppa/ppa.py
53
+++ b/ppa/ppa.py
54
@@ -16,6 +16,10 @@ import sys
55
16
from functools import lru_cache
16
from functools import lru_cache
56
17
from lazr.restfulclient.errors import BadRequest, NotFound
17
from lazr.restfulclient.errors import BadRequest, NotFound
57
18
18
58
19
from .constants import URL_AUTOPKGTEST
59
20
from .io import open_url
60
21
from .job import (get_waiting, get_running)
61
22
62
19
23
63
20
class PpaDoesNotExist(BaseException):
24
class PpaDoesNotExist(BaseException):
64
21
    """Exception indicating a requested PPA could not be found."""
25
    """Exception indicating a requested PPA could not be found."""
65
@@ -376,6 +380,34 @@ class Ppa:
66
376
            print("Successfully published all builds for all architectures")
380
            print("Successfully published all builds for all architectures")
67
377
        return retval
381
        return retval
68
378
382
69
383
    def get_autopkgtest_waiting(self, releases):
70
384
        """Returns iterator of queued autopkgtests for this PPA.
71
385
72
386
        See get_waiting() for details
73
387
74
388
        :param list[str] releases: The Ubuntu series codename(s), or None.
75
389
        :rtype: Iterator[Job]
76
390
        :returns: Currently waiting jobs, if any, or an empty list on error
77
391
        """
78
392
        response = open_url(f"{URL_AUTOPKGTEST}/queues.json", "waiting autopkgtests")
79
393
        if response:
80
394
            return get_waiting(response, releases=releases, ppa=str(self))
81
395
        return []
82
396
83
397
    def get_autopkgtest_running(self, releases):
84
398
        """Returns iterator of queued autopkgtests for this PPA.
85
399
86
400
        See get_running() for details
87
401
88
402
        :param list[str] releases: The Ubuntu series codename(s), or None.
89
403
        :rtype: Iterator[Job]
90
404
        :returns: Currently running jobs, if any, or an empty list on error
91
405
        """
92
406
        response = open_url(f"{URL_AUTOPKGTEST}/static/running.json", "running autopkgtests")
93
407
        if response:
94
408
            return get_running(response, releases=releases, ppa=str(self))
95
409
        return []
96
410
97
379
411
98
380
def ppa_address_split(ppa_address, default_team=None):
412
def ppa_address_split(ppa_address, default_team=None):
99
381
    """Parse an address for a PPA into its team and name components.
413
    """Parse an address for a PPA into its team and name components.
100
diff --git a/ppa/repository.py b/ppa/repository.py
101
index ccd5211..f71b06c 100644
102
--- a/ppa/repository.py
103
+++ b/ppa/repository.py
104
@@ -15,6 +15,10 @@ import os.path
105
15
from functools import lru_cache
15
from functools import lru_cache
106
16
16
107
17
from .suite import Suite
17
from .suite import Suite
108
18
from .constants import (
109
19
    LOCAL_REPOSITORY_PATH,
110
20
    LOCAL_REPOSITORY_MIRRORING_DIRECTIONS
111
21
)
112
18
22
113
19
23
114
20
class Repository:
24
class Repository:
115
@@ -31,6 +35,8 @@ class Repository:
116
31
        """
35
        """
117
32
        if not cache_dir:
36
        if not cache_dir:
118
33
            raise ValueError("undefined cache_dir.")
37
            raise ValueError("undefined cache_dir.")
119
38
        if not os.path.exists(cache_dir):
120
39
            raise FileNotFoundError(f"could not find cache dir '{cache_dir}'")
121
34
40
122
35
        self.cache_dir = cache_dir
41
        self.cache_dir = cache_dir
123
36
42
124
@@ -82,14 +88,15 @@ if __name__ == "__main__":
125
82
    from pprint import PrettyPrinter
88
    from pprint import PrettyPrinter
126
83
    pp = PrettyPrinter(indent=4)
89
    pp = PrettyPrinter(indent=4)
127
84
90
128
91
    from .debug import error
129
92
130
85
    print('#########################')
93
    print('#########################')
131
86
    print('## PpaGroup smoke test ##')
94
    print('## PpaGroup smoke test ##')
132
87
    print('#########################')
95
    print('#########################')
133
88
96
134
89
    LOCAL_REPOSITORY_PATH = "/var/spool/apt-mirror/skel/archive.ubuntu.com/ubuntu"
135
90
    local_dists_path = os.path.join(LOCAL_REPOSITORY_PATH, "dists")
97
    local_dists_path = os.path.join(LOCAL_REPOSITORY_PATH, "dists")
136
91
    if not os.path.exists(local_dists_path):
98
    if not os.path.exists(local_dists_path):
138
92
        print("Error: Missing checkout")
99
        error(f'Missing checkout for smoketest\n{LOCAL_REPOSITORY_MIRRORING_DIRECTIONS}')
139
93
        sys.exit(1)
100
        sys.exit(1)
140
94
    repository = Repository(cache_dir=local_dists_path)
101
    repository = Repository(cache_dir=local_dists_path)
141
95
    for suite in repository.suites.values():
102
    for suite in repository.suites.values():
142
diff --git a/ppa/suite.py b/ppa/suite.py
143
index cbded7a..6e00006 100644
144
--- a/ppa/suite.py
145
+++ b/ppa/suite.py
146
@@ -19,6 +19,12 @@ import apt_pkg
147
19
19
148
20
from .source_package import SourcePackage
20
from .source_package import SourcePackage
149
21
from .binary_package import BinaryPackage
21
from .binary_package import BinaryPackage
150
22
from .constants import (
151
23
    DISTRO_UBUNTU_COMPONENTS,
152
24
    DISTRO_UBUNTU_POCKETS,
153
25
    LOCAL_REPOSITORY_PATH,
154
26
    LOCAL_REPOSITORY_MIRRORING_DIRECTIONS
155
27
)
156
22
28
157
23
29
158
24
class Suite:
30
class Suite:
159
@@ -40,6 +46,8 @@ class Suite:
160
40
            raise ValueError('undefined suite_name.')
46
            raise ValueError('undefined suite_name.')
161
41
        if not cache_dir:
47
        if not cache_dir:
162
42
            raise ValueError('undefined cache_dir.')
48
            raise ValueError('undefined cache_dir.')
163
49
        if not os.path.exists(cache_dir):
164
50
            raise FileNotFoundError(f"could not find cache dir '{cache_dir}'")
165
43
51
166
44
        self._suite_name = suite_name
52
        self._suite_name = suite_name
167
45
        self._cache_dir = cache_dir
53
        self._cache_dir = cache_dir
168
@@ -69,15 +77,28 @@ class Suite:
169
69
    def _rebuild_lookup_tables(self) -> bool:
77
    def _rebuild_lookup_tables(self) -> bool:
170
70
        """Regenerates the provides and rdepends lookup tables.
78
        """Regenerates the provides and rdepends lookup tables.
171
71
79
172
80
        Some packages have build dependence that can be satisfied by one
173
81
        of several packages.  For example, a package may require either
174
82
        awk or mawk to build.  In these cases, the package will be
175
83
        registered in the table as an rdepend for BOTH awk and mawk.
176
84
177
72
        :rtype: bool
85
        :rtype: bool
178
73
        :returns: True if tables were rebuilt, False otherwise"""
86
        :returns: True if tables were rebuilt, False otherwise"""
179
74
        self._provides_table = {}
87
        self._provides_table = {}
180
75
        self._rdepends_table = {}
88
        self._rdepends_table = {}
181
76
        for source_name, source in self.sources.items():
89
        for source_name, source in self.sources.items():
186
77
            print(source_name, source)
90
            for build_dep_binary_names in source.build_dependencies.keys():
187
78
            for build_dep_binary_name in source.build_dependencies.keys():
91
                # This needs to deal with two different kinds of keys.
188
79
                self._rdepends_table.setdefault(build_dep_binary_name, [])
92
                # Basic dependencies are just simple str's, while alternate
189
80
                self._rdepends_table[build_dep_binary_name].append(source)
93
                # dependencies are modeled as tuples.
190
94
                #
191
95
                # So, convert simple str's into single-element lists, so
192
96
                # both cases can be handled via iteration in a for loop.
193
97
                if isinstance(build_dep_binary_names, str):
194
98
                    build_dep_binary_names = [build_dep_binary_names]
195
99
                for build_dep_binary_name in build_dep_binary_names:
196
100
                    self._rdepends_table.setdefault(build_dep_binary_name, [])
197
101
                    self._rdepends_table[build_dep_binary_name].append(source)
198
81
102
199
82
            for provided_binary_name in source.provides_binaries.keys():
103
            for provided_binary_name in source.provides_binaries.keys():
200
83
                self._provides_table[provided_binary_name] = source
104
                self._provides_table[provided_binary_name] = source
201
@@ -124,7 +145,10 @@ class Suite:
202
124
        """
145
        """
203
125
        if '-' not in self.name:
146
        if '-' not in self.name:
204
126
            return 'release'
147
            return 'release'
206
127
        return self.name.split('-')[1]
148
        pocket = self.name.split('-')[1]
207
149
        if pocket not in DISTRO_UBUNTU_POCKETS:
208
150
            raise RuntimeError(f'Unrecognized pocket "{pocket}"')
209
151
        return pocket
210
128
152
211
129
    @property
153
    @property
212
130
    def architectures(self) -> list[str]:
154
    def architectures(self) -> list[str]:
213
@@ -148,6 +172,7 @@ class Suite:
214
148
            component
172
            component
215
149
            for component in os.listdir(self._cache_dir)
173
            for component in os.listdir(self._cache_dir)
216
150
            if os.path.isdir(os.path.join(self._cache_dir, component))
174
            if os.path.isdir(os.path.join(self._cache_dir, component))
217
175
            and component in DISTRO_UBUNTU_COMPONENTS
218
151
        ]
176
        ]
219
152
        if not components:
177
        if not components:
220
153
            raise RuntimeError(f'Could not load components from {self._cache_dir}')
178
            raise RuntimeError(f'Could not load components from {self._cache_dir}')
221
@@ -163,16 +188,22 @@ class Suite:
222
163
188
223
164
        :rtype: dict[str, SourcePackage]
189
        :rtype: dict[str, SourcePackage]
224
165
        """
190
        """
235
166
        sources = {}
191
        sources = None
236
167
        for comp in self.components:
192
        for sources_file in ['Sources.xz', 'Sources.gz']:
237
168
            source_packages_dir = f'{self._cache_dir}/{comp}/source'
193
            for comp in self.components:
238
169
            with apt_pkg.TagFile(f'{source_packages_dir}/Sources.xz') as pkgs:
194
                source_packages_dir = f'{self._cache_dir}/{comp}/source'
239
170
                for pkg in pkgs:
195
                try:
240
171
                    name = pkg['Package']
196
                    with apt_pkg.TagFile(f'{source_packages_dir}/{sources_file}') as pkgs:
241
172
                    sources[name] = SourcePackage(dict(pkg))
197
                        if sources is None:
242
173
        if not sources:
198
                            sources = {}
243
174
            raise RuntimeError(f'Could not load {source_packages_dir}/Sources.xz')
199
                        for pkg in pkgs:
244
175
        return sources
200
                            name = pkg['Package']
245
201
                            sources[name] = SourcePackage(dict(pkg))
246
202
                except apt_pkg.Error:
247
203
                    pass
248
204
            if sources is not None:
249
205
                return sources
250
206
        raise RuntimeError(f'Could not load {source_packages_dir}/Sources.[xz|gz]')
251
176
207
252
177
    @property
208
    @property
253
178
    @lru_cache
209
    @lru_cache
254
@@ -184,38 +215,45 @@ class Suite:
255
184
215
256
185
        :rtype: dict[str, BinaryPackage]
216
        :rtype: dict[str, BinaryPackage]
257
186
        """
217
        """
276
187
        binaries = {}
218
        binaries = None
277
188
        for comp in self.components:
219
        for packages_file in ["Packages.xz", "Packages.gz"]:
278
189
            for arch in self.architectures:
220
            for comp in self.components:
279
190
                binary_packages_dir = f'{self._cache_dir}/{comp}/binary-{arch}'
221
                for arch in self.architectures:
280
191
                try:
222
                    binary_packages_dir = f'{self._cache_dir}/{comp}/binary-{arch}'
281
192
                    with apt_pkg.TagFile(f'{binary_packages_dir}/Packages.xz') as pkgs:
223
                    try:
282
193
                        for pkg in pkgs:
224
                        with apt_pkg.TagFile(f'{binary_packages_dir}/{packages_file}') as pkgs:
283
194
                            name = f'{pkg["Package"]}:{arch}'
225
                            if binaries is None:
284
195
                            binaries[name] = BinaryPackage(pkg)
226
                                binaries = {}
285
196
                except apt_pkg.Error:
227
                            for pkg in pkgs:
286
197
                    # If an Apt repository is incomplete, such as if
228
                                name = f'{pkg["Package"]}:{arch}'
287
198
                    # a given architecture was not mirrored, still
229
                                binaries[name] = BinaryPackage(pkg)
288
199
                    # note the binaries exist but mark their records
230
                    except apt_pkg.Error:
289
200
                    # as missing.
231
                        pass
290
201
                    binaries[name] = None
232
            if binaries is not None:
291
202
        if not binaries:
233
                return binaries
292
203
            raise ValueError(f'Could not load {binary_packages_dir}/Packages.xz')
234
        raise ValueError(f'Could not load {binary_packages_dir}/Packages.[xz|gz]')
275
204
        return binaries
293
205
235
294
206
    def dependent_packages(self, source_package: SourcePackage) -> dict[str, SourcePackage]:
236
    def dependent_packages(self, source_package: SourcePackage) -> dict[str, SourcePackage]:
295
207
        """Relevant packages to run autotests against for a given source package.
237
        """Relevant packages to run autotests against for a given source package.
296
208
238
299
209
        Calculates the collection of build and reverse dependencies for
239
        Calculates the collection of reverse dependencies for a given
300
210
        a given source package, that would be appropriate to re-run autopkgtests
240
        source package that would be appropriate to re-run autopkgtests
301
211
        on, using the given @param source_package's name as a trigger.
241
        on, using the given @param source_package's name as a trigger.
302
212
242
303
243
        For leaf packages (that nothing else depends on as a build
304
244
        requirement), this routine returns an empty dict.
305
245
306
246
        For packages that can serve as an alternative dependency of some
307
247
        packages, this will include all such packages as if they were
308
248
        hard dependencies.  For example, when examining postgresql-12, this
309
249
        would include all packages dependent on any database.
310
250
311
213
        :param str source_package_name: The archive name of the source package.
251
        :param str source_package_name: The archive name of the source package.
312
214
        :rtype: dict[str, SourcePackage]
252
        :rtype: dict[str, SourcePackage]
313
215
        :returns: Collection of source packages, keyed by name.
253
        :returns: Collection of source packages, keyed by name.
314
216
        """
254
        """
315
217
        # Build the lookup table for provides and rdepends
255
        # Build the lookup table for provides and rdepends
317
218
        if not self._provides_table or not self._rdepends_table:
256
        if not self._rdepends_table:
318
219
            if not self._rebuild_lookup_tables():
257
            if not self._rebuild_lookup_tables():
319
220
                raise RuntimeError("Could not regenerate provides/rdepends lookup tables")
258
                raise RuntimeError("Could not regenerate provides/rdepends lookup tables")
320
221
259
321
@@ -228,35 +266,26 @@ class Suite:
322
228
                for rdep_source in rdeps:
266
                for rdep_source in rdeps:
323
229
                    dependencies[rdep_source.name] = rdep_source
267
                    dependencies[rdep_source.name] = rdep_source
324
230
268
325
231
        # Get source packages that provide our build dependencies
326
232
        for build_dependency_name in source_package.build_dependencies.keys():
327
233
            bdep_source = self._provides_table.get(build_dependency_name)
328
234
            if not bdep_source:
329
235
                raise RuntimeError(f'Could not get source object for bdep {build_dependency_name}')
330
236
            dependencies[bdep_source.name] = bdep_source
331
237
332
238
        if not dependencies:
333
239
            raise RuntimeError(f'Could not calculate dependencies for {source_package.name}')
334
240
        return dependencies
269
        return dependencies
335
241
270
336
242
271
337
243
if __name__ == '__main__':
272
if __name__ == '__main__':
338
244
    # pylint: disable=invalid-name
273
    # pylint: disable=invalid-name
339
245
    import sys
274
    import sys
340
246
    from .repository import Repository
341
247
342
248
    from pprint import PrettyPrinter
275
    from pprint import PrettyPrinter
343
249
    pp = PrettyPrinter(indent=4)
276
    pp = PrettyPrinter(indent=4)
344
250
277
345
278
    from .repository import Repository
346
279
    from .debug import error
347
280
348
251
    print('############################')
281
    print('############################')
349
252
    print('## Suite class smoke test ##')
282
    print('## Suite class smoke test ##')
350
253
    print('############################')
283
    print('############################')
351
254
    print()
284
    print()
352
255
285
353
256
    LOCAL_REPOSITORY_PATH = '/var/spool/apt-mirror/skel/archive.ubuntu.com/ubuntu'
354
257
    local_dists_path = os.path.join(LOCAL_REPOSITORY_PATH, 'dists')
286
    local_dists_path = os.path.join(LOCAL_REPOSITORY_PATH, 'dists')
355
258
    if not os.path.exists(local_dists_path):
287
    if not os.path.exists(local_dists_path):
357
259
        print('Error: Missing checkout')
288
        error(f'Missing checkout for suite smoketest\n{LOCAL_REPOSITORY_MIRRORING_DIRECTIONS}')
358
260
        sys.exit(1)
289
        sys.exit(1)
359
261
290
360
262
    repository = Repository(cache_dir=local_dists_path)
291
    repository = Repository(cache_dir=local_dists_path)
361
diff --git a/ppa/trigger.py b/ppa/trigger.py
362
index 234e14a..077dcfc 100755
363
--- a/ppa/trigger.py
364
+++ b/ppa/trigger.py
365
@@ -27,7 +27,7 @@ class Trigger:
366
27
    package and/or architectures, but all such Triggers must be against
27
    package and/or architectures, but all such Triggers must be against
367
28
    the same series as the Job itself.
28
    the same series as the Job itself.
368
29
    """
29
    """
370
30
    def __init__(self, package, version, arch, series, ppa=None):
30
    def __init__(self, package, version, arch, series, ppa=None, test_package=None):
371
31
        """Initializes a new Trigger for a given package and version.
31
        """Initializes a new Trigger for a given package and version.
372
32
32
373
33
        :param str package: The source package name.
33
        :param str package: The source package name.
374
@@ -35,12 +35,17 @@ class Trigger:
375
35
        :param str arch: The architecture for the trigger.
35
        :param str arch: The architecture for the trigger.
376
36
        :param str series: The distro release series codename.
36
        :param str series: The distro release series codename.
377
37
        :param Ppa ppa: (Optional) PPA wrapper object to run tests against.
37
        :param Ppa ppa: (Optional) PPA wrapper object to run tests against.
378
38
        :param str test_package: The package to run autopkgtests from.
379
38
        """
39
        """
380
39
        self.package = package
40
        self.package = package
381
40
        self.version = version
41
        self.version = version
382
41
        self.arch = arch
42
        self.arch = arch
383
42
        self.series = series
43
        self.series = series
384
43
        self.ppa = ppa
44
        self.ppa = ppa
385
45
        if test_package:
386
46
            self.test_package = test_package
387
47
        else:
388
48
            self.test_package = package
389
44
49
390
45
    def __repr__(self) -> str:
50
    def __repr__(self) -> str:
391
46
        """Machine-parsable unique representation of object.
51
        """Machine-parsable unique representation of object.
392
@@ -50,7 +55,8 @@ class Trigger:
393
50
        """
55
        """
394
51
        return (f'{self.__class__.__name__}('
56
        return (f'{self.__class__.__name__}('
395
52
                f'package={self.package!r}, version={self.version!r}, '
57
                f'package={self.package!r}, version={self.version!r}, '
397
53
                f'arch={self.arch!r}, series={self.series!r}, ppa={self.ppa!r})')
58
                f'arch={self.arch!r}, series={self.series!r}, ppa={self.ppa!r}, '
398
59
                f'test_package={self.test_package!r})')
399
54
60
400
55
    def __str__(self) -> str:
61
    def __str__(self) -> str:
401
56
        """Human-readable summary of the object.
62
        """Human-readable summary of the object.
402
@@ -58,6 +64,8 @@ class Trigger:
403
58
        :rtype: str
64
        :rtype: str
404
59
        :returns: Printable summary of the object.
65
        :returns: Printable summary of the object.
405
60
        """
66
        """
406
67
        if self.test_package != self.package:
407
68
            return f"({self.test_package}) {self.package}/{self.version}"
408
61
        return f"{self.package}/{self.version}"
69
        return f"{self.package}/{self.version}"
409
62
70
410
63
    @property
71
    @property
411
@@ -85,7 +93,7 @@ class Trigger:
412
85
        """
93
        """
413
86
        params = [
94
        params = [
414
87
            ("release", self.series),
95
            ("release", self.series),
416
88
            ("package", self.package),
96
            ("package", self.test_package),
417
89
            ("arch", self.arch),
97
            ("arch", self.arch),
418
90
        ]
98
        ]
419
91
99
420
diff --git a/scripts/ppa b/scripts/ppa
421
index 9097004..7200c22 100755
422
--- a/scripts/ppa
423
+++ b/scripts/ppa
424
@@ -70,15 +70,12 @@ from ppa.constants import (
425
70
    ARCHES_PPA_DEFAULT,
70
    ARCHES_PPA_DEFAULT,
426
71
    ARCHES_AUTOPKGTEST,
71
    ARCHES_AUTOPKGTEST,
427
72
    URL_AUTOPKGTEST,
72
    URL_AUTOPKGTEST,
428
73
    LOCAL_REPOSITORY_PATH,
429
74
    LOCAL_REPOSITORY_MIRRORING_DIRECTIONS,
430
73
)
75
)
431
74
from ppa.dict import unpack_to_dict
76
from ppa.dict import unpack_to_dict
432
75
from ppa.io import open_url
77
from ppa.io import open_url
439
76
from ppa.job import (
78
from ppa.job import show_waiting, show_running
434
77
    get_waiting,
435
78
    show_waiting,
436
79
    get_running,
437
80
    show_running
438
81
)
440
82
from ppa.lp import Lp
79
from ppa.lp import Lp
441
83
from ppa.ppa import (
80
from ppa.ppa import (
442
84
    get_ppa,
81
    get_ppa,
443
@@ -87,6 +84,7 @@ from ppa.ppa import (
444
87
    PpaDoesNotExist
84
    PpaDoesNotExist
445
88
)
85
)
446
89
from ppa.ppa_group import PpaGroup, PpaAlreadyExists
86
from ppa.ppa_group import PpaGroup, PpaAlreadyExists
447
87
from ppa.repository import Repository
448
90
from ppa.result import get_results
88
from ppa.result import get_results
449
91
from ppa.text import o2str, ansi_hyperlink
89
from ppa.text import o2str, ansi_hyperlink
450
92
from ppa.trigger import Trigger
90
from ppa.trigger import Trigger
451
@@ -365,6 +363,10 @@ def create_arg_parser() -> argparse.ArgumentParser:
452
365
                              dest='show_urls', action='store_true',
363
                              dest='show_urls', action='store_true',
453
366
                              default=False,
364
                              default=False,
454
367
                              help="Display unformatted trigger action URLs")
365
                              help="Display unformatted trigger action URLs")
455
366
    tests_parser.add_argument('--show-rdepends',
456
367
                              dest='show_rdepends', action='store_true',
457
368
                              default=False,
458
369
                              help="Display test triggers for reverse dependencies")
459
368
370
460
369
    # Wait Command
371
    # Wait Command
461
370
    wait_parser = subparser.add_parser(
372
    wait_parser = subparser.add_parser(
462
@@ -772,6 +774,15 @@ def command_tests(lp, config):
463
772
    if not lp:
774
    if not lp:
464
773
        return 1
775
        return 1
465
774
776
466
777
    apt_repository = None
467
778
    if config.get("show_rdepends"):
468
779
        local_dists_path = os.path.join(LOCAL_REPOSITORY_PATH, "dists")
469
780
        try:
470
781
            apt_repository = Repository(cache_dir=local_dists_path)
471
782
        except FileNotFoundError as e:
472
783
            error(f'Missing checkout\n{LOCAL_REPOSITORY_MIRRORING_DIRECTIONS}')
473
784
            return 1
474
785
475
775
    releases = config.get('releases', None)
786
    releases = config.get('releases', None)
476
776
    if releases is None:
787
    if releases is None:
477
777
        udi = UbuntuDistroInfo()
788
        udi = UbuntuDistroInfo()
478
@@ -792,8 +803,8 @@ def command_tests(lp, config):
479
792
        # Triggers
803
        # Triggers
480
793
        print("* Triggers:")
804
        print("* Triggers:")
481
794
        for source_pub in the_ppa.get_source_publications():
805
        for source_pub in the_ppa.get_source_publications():
484
795
            series = source_pub.distro_series.name
806
            series_codename = source_pub.distro_series.name
485
796
            if series not in releases:
807
            if series_codename not in releases:
486
797
                continue
808
                continue
487
798
            pkg = source_pub.source_package_name
809
            pkg = source_pub.source_package_name
488
799
            if packages and (pkg not in packages):
810
            if packages and (pkg not in packages):
489
@@ -802,28 +813,64 @@ def command_tests(lp, config):
490
802
            url = f"https://launchpad.net/ubuntu/+source/{pkg}/{ver}"
813
            url = f"https://launchpad.net/ubuntu/+source/{pkg}/{ver}"
491
803
            source_hyperlink = ansi_hyperlink(url, f"{pkg}/{ver}")
814
            source_hyperlink = ansi_hyperlink(url, f"{pkg}/{ver}")
492
804
            print(f"  - Source {source_hyperlink}: {source_pub.status}")
815
            print(f"  - Source {source_hyperlink}: {source_pub.status}")
494
805
            triggers = [Trigger(pkg, ver, arch, series, the_ppa) for arch in architectures]
816
            triggers = [Trigger(pkg, ver, arch, series_codename, the_ppa) for arch in architectures]
495
817
496
818
            rdepends = None
497
819
            if config.get("show_rdepends"):
498
820
                # Construct suite object from repository.
499
821
                # NOTE: If a package has been freshly added to 'proposed' it
500
822
                #       will be missed since we consider only packages present
501
823
                #       in the release pocket.
502
824
                suite = apt_repository.get_suite(series_codename, 'release')
503
825
                if not suite:
504
826
                    raise RuntimeError(f'Could not find suite for "{series_codename}" in the local Apt cache')
505
827
506
828
                # Lookup rdepends for the package
507
829
                source_package = suite.sources.get(pkg)
508
830
                if not source_package:
509
831
                    raise RuntimeError(f'Could not find source package "{pkg}" in the local Apt cache for "{suite}"')
510
832
511
833
                rdepends_source_package_names = suite.dependent_packages(source_package)
512
834
                for rdep_name in rdepends_source_package_names:
513
835
                    rdep = suite.sources.get(rdep_name)
514
836
                    if not rdep:
515
837
                        raise RuntimeError(f'Undefined reverse dependency "{rdep_name}"')
516
838
517
839
                    triggers.extend([
518
840
                        Trigger(pkg, ver, arch, series_codename, the_ppa, rdep.name)
519
841
                        for arch
520
842
                        in architectures
521
843
                    ])
522
806
844
523
807
            if config.get("show_urls"):
845
            if config.get("show_urls"):
524
808
                for trigger in triggers:
846
                for trigger in triggers:
526
809
                    print(f"    + {trigger.arch}: {trigger.action_url}♻️ ")
847
                    title = ''
527
848
                    if config.get('show_rdepends'):
528
849
                        title = trigger.test_package
529
850
                    print(f"    + {title}@{trigger.arch}: {trigger.action_url}♻️ ")
530
810
                for trigger in triggers:
851
                for trigger in triggers:
532
811
                    print(f"    + {trigger.arch}: {trigger.action_url}💍")
852
                    title = ''
533
853
                    if config.get('show_rdepends'):
534
854
                        title = trigger.test_package
535
855
                        print(f"    + {trigger.package}@{trigger.arch}: {trigger.action_url}💍")
536
812
856
537
813
            else:
857
            else:
538
814
                for trigger in triggers:
858
                for trigger in triggers:
539
815
                    pad = ' ' * (1 + abs(len('ppc64el') - len(trigger.arch)))
859
                    pad = ' ' * (1 + abs(len('ppc64el') - len(trigger.arch)))
540
860
                    title = ''
541
861
                    if config.get('show_rdepends'):
542
862
                        title = trigger.test_package
543
863
544
816
                    basic_trig = ansi_hyperlink(
864
                    basic_trig = ansi_hyperlink(
546
817
                        trigger.action_url, f"Trigger basic @{trigger.arch}♻️ "
865
                        trigger.action_url, f"Trigger basic {title}@{trigger.arch}♻️ "
547
818
                    )
866
                    )
548
819
                    all_proposed_trig = ansi_hyperlink(
867
                    all_proposed_trig = ansi_hyperlink(
549
820
                        trigger.action_url + "&all-proposed=1",
868
                        trigger.action_url + "&all-proposed=1",
551
821
                        f"Trigger all-proposed @{trigger.arch}💍"
869
                        f"Trigger all-proposed {title}@{trigger.arch}💍"
552
822
                    )
870
                    )
553
823
                    print(f"    + " + pad.join([basic_trig, all_proposed_trig]))
871
                    print(f"    + " + pad.join([basic_trig, all_proposed_trig]))
554
824
872
555
825
        # Results
873
        # Results
556
826
        print()
557
827
        print("* Results:")
874
        print("* Results:")
558
828
        for release in releases:
875
        for release in releases:
559
829
            base_results_fmt = f"{URL_AUTOPKGTEST}/results/autopkgtest-%s-%s-%s/"
876
            base_results_fmt = f"{URL_AUTOPKGTEST}/results/autopkgtest-%s-%s-%s/"
560
@@ -850,18 +897,14 @@ def command_tests(lp, config):
561
850
                                trigger_sets[trigger] += f"      • {subtest}\n"
897
                                trigger_sets[trigger] += f"      • {subtest}\n"
562
851
898
563
852
                for trigger, result in trigger_sets.items():
899
                for trigger, result in trigger_sets.items():
565
853
                    print(f"  - {trigger}\n{result}")
900
                    print(f"  - {trigger}\n{result.rstrip()}")
566
854
901
567
855
        # Running Queue
902
        # Running Queue
572
856
        response = open_url(f"{URL_AUTOPKGTEST}/static/running.json", "running autopkgtests")
903
        show_running(sorted(the_ppa.get_autopkgtest_running(releases),
573
857
        if response:
904
                            key=lambda k: str(k.submit_time)))
570
858
            show_running(sorted(get_running(response, releases=releases, ppa=str(the_ppa)),
571
859
                                key=lambda k: str(k.submit_time)))
574
860
905
575
861
        # Waiting Queue
906
        # Waiting Queue
579
862
        response = open_url(f"{URL_AUTOPKGTEST}/queues.json", "waiting autopkgtests")
907
        show_waiting(the_ppa.get_autopkgtest_waiting(releases))
577
863
        if response:
578
864
            show_waiting(get_waiting(response, releases=releases, ppa=str(the_ppa)))
580
865
908
581
866
        return os.EX_OK
909
        return os.EX_OK
582
867
    except KeyboardInterrupt:
910
    except KeyboardInterrupt:
583
diff --git a/tests/helpers.py b/tests/helpers.py
584
index 2329125..3a0d2d4 100644
585
--- a/tests/helpers.py
586
+++ b/tests/helpers.py
587
@@ -19,6 +19,19 @@ from ppa.constants import ARCHES_PPA_DEFAULT
588
19
from ppa.ppa_group import PpaAlreadyExists
19
from ppa.ppa_group import PpaAlreadyExists
589
20
20
590
21
21
591
22
class SeriesMock:
592
23
    def __init__(self, name):
593
24
        self.name = name
594
25
595
26
596
27
class PublicationMock:
597
28
    def __init__(self, name, version, status, series):
598
29
        self.source_package_name = name
599
30
        self.source_package_version = version
600
31
        self.status = status
601
32
        self.distro_series = SeriesMock(series)
602
33
603
34
604
22
class ProcessorMock:
35
class ProcessorMock:
605
23
    """A stand-in for a Launchpad Processor object."""
36
    """A stand-in for a Launchpad Processor object."""
606
24
    def __init__(self, name):
37
    def __init__(self, name):
607
@@ -32,10 +45,14 @@ class ArchiveMock:
608
32
        self.description = description
45
        self.description = description
609
33
        self.publish = True
46
        self.publish = True
610
34
        self.processors = [ProcessorMock(proc_name) for proc_name in ARCHES_PPA_DEFAULT]
47
        self.processors = [ProcessorMock(proc_name) for proc_name in ARCHES_PPA_DEFAULT]
611
48
        self.published_sources = []
612
35
49
613
36
    def setProcessors(self, processors):
50
    def setProcessors(self, processors):
614
37
        self.processors = [ProcessorMock(proc.split('/')[-1]) for proc in processors]
51
        self.processors = [ProcessorMock(proc.split('/')[-1]) for proc in processors]
615
38
52
616
53
    def getPublishedSources(self):
617
54
        return self.published_sources
618
55
619
39
    def lp_save(self):
56
    def lp_save(self):
620
40
        return True
57
        return True
621
41
58
622
diff --git a/tests/test_scripts_ppa.py b/tests/test_scripts_ppa.py
623
index a107f92..c4dca3d 100644
624
--- a/tests/test_scripts_ppa.py
625
+++ b/tests/test_scripts_ppa.py
626
@@ -18,16 +18,21 @@ import types
627
18
import importlib.machinery
18
import importlib.machinery
628
19
import argparse
19
import argparse
629
20
import pytest
20
import pytest
630
21
from mock import patch
631
21
22
632
22
SCRIPT_NAME = "ppa"
23
SCRIPT_NAME = "ppa"
633
23
BASE_PATH = os.path.realpath(os.path.join(os.path.dirname(os.path.realpath(__file__)), ".."))
24
BASE_PATH = os.path.realpath(os.path.join(os.path.dirname(os.path.realpath(__file__)), ".."))
634
24
sys.path.insert(0, BASE_PATH)
25
sys.path.insert(0, BASE_PATH)
635
25
26
636
27
from ppa.ppa import Ppa
637
26
from ppa.constants import (
28
from ppa.constants import (
638
27
    ARCHES_PPA_ALL,
29
    ARCHES_PPA_ALL,
639
28
    ARCHES_PPA_DEFAULT
30
    ARCHES_PPA_DEFAULT
640
29
)
31
)
642
30
from tests.helpers import LpServiceMock
32
from tests.helpers import (
643
33
    LpServiceMock,
644
34
    PublicationMock
645
35
)
646
31
36
647
32
if '.pybuild' in BASE_PATH:
37
if '.pybuild' in BASE_PATH:
648
33
    python_version = '.'.join([str(v) for v in sys.version_info[0:2]])
38
    python_version = '.'.join([str(v) for v in sys.version_info[0:2]])
649
@@ -363,6 +368,14 @@ def test_create_arg_parser_tests():
650
363
    assert args.show_urls is True
368
    assert args.show_urls is True
651
364
    args.show_urls = None
369
    args.show_urls = None
652
365
370
653
371
    # Check --show-rdepends
654
372
    args = parser.parse_args([command, 'tests-ppa'])
655
373
    assert args.show_rdepends is False
656
374
    args.show_rdepends = None
657
375
    args = parser.parse_args([command, 'tests-ppa', '--show-rdepends'])
658
376
    assert args.show_rdepends is True
659
377
    args.show_rdepends = None
660
378
661
366
379
662
367
@pytest.mark.parametrize('command_line_options, expected_config', [
380
@pytest.mark.parametrize('command_line_options, expected_config', [
663
368
    pytest.param([], {}),
381
    pytest.param([], {}),
664
@@ -578,6 +591,42 @@ def test_command_status(fake_config):
665
578
    # TODO: Capture stdout and compare with expected
591
    # TODO: Capture stdout and compare with expected
666
579
592
667
580
593
668
594
@pytest.mark.parametrize('params, format, expected_in_stdout', [
669
595
    (
670
596
        {
671
597
            'releases': None,
672
598
            'architectures': 'amd64',
673
599
            'show_urls': True
674
600
        },
675
601
        'plain',
676
602
        'arch=amd64&trigger=x%2F1&ppa=me%2Ftesting'
677
603
    ),
678
604
])
679
605
@patch('urllib.request.urlopen')
680
606
@patch('ppa.io.open_url')
681
607
def test_command_tests(urlopen_mock,
682
608
                       open_url_mock,
683
609
                       fake_config, capfd, params, format, expected_in_stdout):
684
610
    '''Checks that the tests command retrieves and displays correct results.'''
685
611
    lp = LpServiceMock()
686
612
    urlopen_mock.return_value = "{}"
687
613
    Ppa.get_autopkgtest_running = lambda x, y: []
688
614
    Ppa.get_autopkgtest_waiting = lambda x, y: []
689
615
690
616
    # Create a default PPA, for modification later
691
617
    team = lp.people[fake_config['team_name']]
692
618
    team.createPPA(fake_config['ppa_name'], 'x', 'y')
693
619
    the_ppa = lp.me.getPPAByName(fake_config['ppa_name'])
694
620
695
621
    # Add some fake publications
696
622
    the_ppa.published_sources.append(PublicationMock('x', '1', 'Published', 'jammy'))
697
623
698
624
    config = {**fake_config, **params}
699
625
    assert script.command_tests(lp, config) == 0
700
626
    out, err = capfd.readouterr()
701
627
    assert expected_in_stdout in out
702
628
703
629
704
581
@pytest.mark.xfail(reason="Unimplemented")
630
@pytest.mark.xfail(reason="Unimplemented")
705
582
def test_command_wait(fake_config):
631
def test_command_wait(fake_config):
706
583
    # TODO: Set wait period to 1 sec
632
    # TODO: Set wait period to 1 sec
707
diff --git a/tests/test_suite.py b/tests/test_suite.py
708
index 0dd430d..c6580b1 100644
709
--- a/tests/test_suite.py
710
+++ b/tests/test_suite.py
711
@@ -27,8 +27,8 @@ from ppa.binary_package import BinaryPackage
712
27
27
713
28
28
714
29
@pytest.mark.parametrize('suite_name, cache_dir, expected_repr, expected_str', [
29
@pytest.mark.parametrize('suite_name, cache_dir, expected_repr, expected_str', [
717
30
    ('x', 'x', "Suite(suite_name='x', cache_dir='x')", "x"),
30
    ('x', '/tmp', "Suite(suite_name='x', cache_dir='/tmp')", "x"),
718
31
    ('a-1', 'x', "Suite(suite_name='a-1', cache_dir='x')", "a-1"),
31
    ('a-1', '/tmp', "Suite(suite_name='a-1', cache_dir='/tmp')", "a-1"),
719
32
    ('b-2', '/tmp', "Suite(suite_name='b-2', cache_dir='/tmp')", "b-2"),
32
    ('b-2', '/tmp', "Suite(suite_name='b-2', cache_dir='/tmp')", "b-2"),
720
33
])
33
])
721
34
def test_object(suite_name, cache_dir, expected_repr, expected_str):
34
def test_object(suite_name, cache_dir, expected_repr, expected_str):
722
@@ -43,6 +43,7 @@ def test_object(suite_name, cache_dir, expected_repr, expected_str):
723
43
@pytest.mark.parametrize('suite_name, cache_dir, expected_exception', [
43
@pytest.mark.parametrize('suite_name, cache_dir, expected_exception', [
724
44
    ('x', '', ValueError),
44
    ('x', '', ValueError),
725
45
    ('', 'x', ValueError),
45
    ('', 'x', ValueError),
726
46
    ('x', 'x', FileNotFoundError),
727
46
    ('', '', ValueError),
47
    ('', '', ValueError),
728
47
    ('a-1', None, ValueError),
48
    ('a-1', None, ValueError),
729
48
    (None, 'x', ValueError),
49
    (None, 'x', ValueError),
730
@@ -127,7 +128,7 @@ def test_series_codename(monkeypatch, info, expected_series_codename):
731
127
128
732
128
@pytest.mark.parametrize('info, expected_pocket', [
129
@pytest.mark.parametrize('info, expected_pocket', [
733
129
    ({'Suite': 'x'}, 'release'),
130
    ({'Suite': 'x'}, 'release'),
735
130
    ({'Suite': 'x-y'}, 'y'),
131
    ({'Suite': 'x-backports'}, 'backports'),
736
131
    ({'Suite': 'lunar'}, 'release'),
132
    ({'Suite': 'lunar'}, 'release'),
737
132
    ({'Suite': 'lunar-proposed'}, 'proposed'),
133
    ({'Suite': 'lunar-proposed'}, 'proposed'),
738
133
    ({'Suite': 'focal-security'}, 'security'),
134
    ({'Suite': 'focal-security'}, 'security'),
739
@@ -159,9 +160,9 @@ def test_architectures(monkeypatch, info, expected_architectures):
740
159
160
741
160
161
742
161
@pytest.mark.parametrize('suite_name, component_paths, expected_components', [
162
@pytest.mark.parametrize('suite_name, component_paths, expected_components', [
746
162
    ('a-1', ['a-1/x', 'a-1/y', 'a-1/z'], ['x', 'y', 'z']),
163
    ('a-1', ['a-1/main', 'a-1/universe', 'a-1/multiverse'], ['main', 'universe', 'multiverse']),
747
163
    ('a-1', ['a-1/x', 'b-1/y', 'c-1/z'], ['x']),
164
    ('a-1', ['a-1/main', 'b-1/universe', 'c-1/multiverse'], ['main']),
748
164
    ('a-1', ['a-1/x', 'a-1/x/y', 'c-1/z/x'], ['x']),
165
    ('a-1', ['a-1/main', 'a-1/main/y', 'c-1/multiverse/x'], ['main']),
749
165
    ('x', ['x/main', 'x/restricted', 'x/universe', 'x/multiverse'],
166
    ('x', ['x/main', 'x/restricted', 'x/universe', 'x/multiverse'],
750
166
     ['main', 'restricted', 'universe', 'multiverse']),
167
     ['main', 'restricted', 'universe', 'multiverse']),
751
167
])
168
])
752
@@ -553,7 +554,7 @@ def test_rebuild_tables_mapping(monkeypatch):
753
553
            {'Package': 'd', 'Version': 'x', 'Build-Depends': 'a1, b1, c2', 'Binary': 'd1'},
554
            {'Package': 'd', 'Version': 'x', 'Build-Depends': 'a1, b1, c2', 'Binary': 'd1'},
754
554
        ],
555
        ],
755
555
        'd',
556
        'd',
757
556
        ['a', 'b', 'c'],
557
        ['a'],
758
557
    ),
558
    ),
759
558
])
559
])
760
559
def test_dependent_packages(monkeypatch, sources_dict, source_package_name, expected_packages):
560
def test_dependent_packages(monkeypatch, sources_dict, source_package_name, expected_packages):
761
diff --git a/tests/test_trigger.py b/tests/test_trigger.py
762
index c2b1702..e2a2350 100644
763
--- a/tests/test_trigger.py
764
+++ b/tests/test_trigger.py
765
@@ -27,10 +27,16 @@ def test_object():
766
27
    assert trigger
27
    assert trigger
767
28
28
768
29
29
770
30
def test_repr():
30
@pytest.mark.parametrize('pkg, ver, arch, series, ppa, testpkg, expected_repr', [
771
31
    ('a', 'b', 'c', 'd', 'e', 'f',
772
32
     "Trigger(package='a', version='b', arch='c', series='d', ppa='e', test_package='f')"),
773
33
    ('a', 'b', 'c', 'd', 'e', None,
774
34
     "Trigger(package='a', version='b', arch='c', series='d', ppa='e', test_package='a')"),
775
35
])
776
36
def test_repr(pkg, ver, arch, series, ppa, testpkg, expected_repr):
777
31
    """Checks Trigger object representation."""
37
    """Checks Trigger object representation."""
780
32
    trigger = Trigger('a', 'b', 'c', 'd', 'e')
38
    trigger = Trigger(pkg, ver, arch, series, ppa, testpkg)
781
33
    assert repr(trigger) == "Trigger(package='a', version='b', arch='c', series='d', ppa='e')"
39
    assert repr(trigger) == expected_repr
782
34
40
783
35
41
784
36
def test_str():
42
def test_str():
785
@@ -72,6 +78,12 @@ def test_history_url(trigger, expected):
786
72
    ), (
78
    ), (
787
73
        Trigger('nut', '2.7.4-1', 'armhf', 'jammy', None),
79
        Trigger('nut', '2.7.4-1', 'armhf', 'jammy', None),
788
74
        "/request.cgi?release=jammy&package=nut&arch=armhf&trigger=nut%2F2.7.4-1"
80
        "/request.cgi?release=jammy&package=nut&arch=armhf&trigger=nut%2F2.7.4-1"
789
81
    ), (
790
82
        Trigger('apache2', '2.4', 'amd64', 'kinetic', 'ppa:aaa/bbb'),
791
83
        "/request.cgi?release=kinetic&package=apache2&arch=amd64&trigger=apache2%2F2.4&ppa=ppa%3Aaaa%2Fbbb"
792
84
    ), (
793
85
        Trigger('apache2', '2.4', 'amd64', 'kinetic', 'ppa:aaa/bbb', 'cinder'),
794
86
        "/request.cgi?release=kinetic&package=cinder&arch=amd64&trigger=apache2%2F2.4&ppa=ppa%3Aaaa%2Fbbb"
795
75
    )
87
    )
796
76
])
88
])
797
77
def test_action_url(trigger, expected):
89
def test_action_url(trigger, expected):
Status:	Merged
Merge reported by:	Bryce Harrington
Merged at revision:	565c3c6342b9f5c57808b7d527daeb1b555070c2
Proposed branch:	ppa-dev-tools:add_rdepends_argument
Merge into:	ppa-dev-tools:main
Diff against target:	797 lines (+318/-87) 11 files modified NEWS.md (+16/-0) ppa/constants.py (+17/-0) ppa/ppa.py (+32/-0) ppa/repository.py (+9/-2) ppa/suite.py (+78/-49) ppa/trigger.py (+11/-3) scripts/ppa (+65/-22) tests/helpers.py (+17/-0) tests/test_scripts_ppa.py (+50/-1) tests/test_suite.py (+8/-7) tests/test_trigger.py (+15/-3)
Related bugs:	Link a bug report
Reviewer	Date Requested	Status
Sergio Durigan Junior (community)	2023-04-18	Approve on 2023-04-24
Canonical Server	2023-04-18	Pending
Canonical Server Reporter	2023-04-18	Pending
Review via email: mp+441377@code.launchpad.net