Code review comment for ppa-dev-tools:add_rdepends_argument

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the detailed explanation, Bryce.

Yes, absolutely no problem to leave this further automation for the next release. I'm glad that we're on the same page on this topic!

I'm leaving a few cosmetic comments below, but otherwise the code looks good to me, so I'm approving the MP. But I have a few other general comments.

- I set up a container in order to fully test the package (including installing it), and I stumbled upon a few problems with missing requirements from the requirements-dev.txt file.

- When I tried running the "tests --show-rdepends" command against a public PPA, it asked me to log into LP. This shouldn't really be necessary, unless dealing with private PPAs and such. It's not something really important to address right now (I understand that you have other things on your plate), but it's something to keep in mind IMHO.

Thanks again for working on this.

review: Approve

« Back to merge proposal