Merge ppa-dev-tools:improve-tests-command-argument-behaviors into ppa-dev-tools:main

[Bryce Harrington]

Three bugfixes for the `ppa tests` command, reported by Brian and Christian.

These changes should be straightforward. Normally I'd include pytest cases with these as well, but I'm working on the `ppa tests` test cases in another branch so will postpone that for now.

[Christian Ehrhardt  (paelzer)]

All three changes LGTM, thanks for continuously improving the tool!

BTW I might have more users for the "reverse dependency based tests" as done by propose migration :-)

review: Approve

[Bryce Harrington (bryce)]

On Tue, Feb 14, 2023 at 09:30:09AM -0000, Christian Ehrhardt  wrote:
> Review: Approve
>
> All three changes LGTM, thanks for continuously improving the tool!

Thanks, pushed:

To git+ssh://git.launchpad.net/ppa-dev-tools
   321446a..8ca9a46 main -> main

> BTW I might have more users for the "reverse dependency based tests" as done by propose migration :-)

Great!

diff --git a/scripts/ppa b/scripts/ppa
index fbf65f2..6be138e 100755
--- a/scripts/ppa
+++ b/scripts/ppa
@@ -52,7 +52,7 @@ import time
 import argparse
 from inspect import currentframe
 from textwrap import indent
-from distro_info import UbuntuDistroInfo, DistroDataOutdated
+from distro_info import UbuntuDistroInfo
 
 try:
     from ruamel import yaml
@@ -175,6 +175,7 @@ def add_basic_config_options(parser) -> None:
         '--displayname',
         dest="displayname",
         action='store',
+        default=None,
         help="A short title for the PPA's web page."
     )
 
@@ -183,6 +184,7 @@ def add_basic_config_options(parser) -> None:
         '--description',
         dest="description",
         action='store',
+        default=None,
         help="A short description of the archive.  URLs will be rendered as links.  (See also 'ppa desc'.)"
     )
 
@@ -295,9 +297,11 @@ def create_arg_parser():
                              help="Name of the PPA to show")
     show_parser.add_argument('-a', '--arches', '--arch', '--architectures',
                              dest="architectures", action='store',
+                             default=None,
                              help="Comma-separated list of hardware architectures to show")
     show_parser.add_argument('-r', '--releases', '--release',
                              dest="releases", action='store',
+                             default=None,
                              help="Comma-separated list of Ubuntu release codenames to show")
     show_parser.add_argument('-p', '--packages', '--package',
                              dest="packages", action='store',
@@ -313,6 +317,7 @@ def create_arg_parser():
     add_global_options(status_parser)
     status_parser.add_argument('ppa_name', metavar='ppa-name',
                                action='store',
+                               default=None,
                                help="Name of the PPA to report status of")
 
     # Tests Command
@@ -325,18 +330,23 @@ def create_arg_parser():
     add_global_options(tests_parser)
     tests_parser.add_argument('ppa_name', metavar='ppa-name',
                               action='store',
+                              default=None,
                               help="Name of the PPA to view tests")
     tests_parser.add_argument('-a', '--arches', '--arch', '--architectures',
                               dest="architectures", action='store',
+                              default=None,
                               help="Comma-separated list of hardware architectures to include")
     tests_parser.add_argument('-r', '--releases', '--release',
                               dest="releases", action='store',
+                              default=None,
                               help="Comma-separated list of Ubuntu release codenames to show")
     tests_parser.add_argument('-p', '--packages', '--package',
                               dest="packages", action='store',
+                              default=None,
                               help="Comma-separated list of source package names to show")
     tests_parser.add_argument('-L', '--show-url', '--show-urls',
-                              dest='show_urls', action='store_true', default=False,
+                              dest='show_urls', action='store_true',
+                              default=False,
                               help="Display unformatted trigger action URLs")
 
     # Wait Command
@@ -761,14 +771,7 @@ def command_tests(lp, config):
     releases = config.get('releases', None)
     if releases is None:
         udi = UbuntuDistroInfo()
-        try:
-            # Show tests only from the current development release
-            releases = [udi.devel()]
-        except DistroDataOutdated as e:
-            # If no development release defined, use the current active release
-            warn(f"Devel release is undefined; assuming stable release instead.")
-            dbg(f"({e})", wrap=72, prefix='  - ', indent='    ')
-            releases = [udi.stable()]
+        releases = udi.supported()
 
     packages = config.get('packages', None)
 
@@ -828,9 +831,9 @@ def command_tests(lp, config):
                     trigger_sets.setdefault(trigger, '')
                     if config.get("show_urls"):
                         trigger_sets[trigger] += f"    + {result.status_icon} {result}\n"
+                        trigger_sets[trigger] += f"      • Log: {result.url}\n"
                         if result.status != 'PASS':
                             trigger_sets[trigger] += f"      • Status: {result.status}\n"
-                            trigger_sets[trigger] += f"      • Log: {result.url}\n"
                             for subtest in result.get_subtests():
                                 trigger_sets[trigger] += f"      • {subtest}\n"
                     else: