Last commit made on 2023-02-14
Get this branch:
git clone -b improve-tests-command-argument-behaviors https://git.launchpad.net/ppa-dev-tools
Only Bryce Harrington can upload to this branch. If you are Bryce Harrington please log in for upload directions.

Branch merges

Branch information


Recent commits

8ca9a46... by Bryce Harrington

ppa: When no release is specified, default to supported releases

Previously we were assuming the devel release (i.e. lunar currently),
however if a PPA doesn't have builds for that release there will nothing
in the output except the headers. That looks wrong and doesn't really
fit user expectations.

Instead, make the default be all currently supported Ubuntu
releases (i.e. bionic, focal, jammy, kinetic, and lunar presently). The
display code already skips output for releases that the PPA doesn't
have builds for.

Fixes: https://bugs.launchpad.net/ppa-dev-tools/+bug/2003094

73afeb8... by Bryce Harrington

ppa: Force display of the result log URL if --show-urls given

For brevity we omit some of the details for passing results, however if
the user has specified the --show-urls argument explicitly, they
likely will expect to see log urls for both passing and failing results.

Fixes: https://bugs.launchpad.net/ppa-dev-tools/+bug/2006400

f25a764... by Bryce Harrington

ppa: Set default to None for args with action store

argparse does not create Namespace attributes for arguments that the
user doesn't specify on the command line when configured with
action='store'. Explicitly setting default=None forces the attributes
to be included in the Namespace object, allowing the args to be checked
for presence.

Fixes: https://bugs.launchpad.net/ppa-dev-tools/+bug/2006377

321446a... by Bryce Harrington

create: Add unit test

I don't think this test case needs to test the team name or ppa address
since those are already adequately covered by test_ppa_group.py. This
test basically just needs to verify the specified command line arguments
were interpreted and applied correctly.

436a47d... by Bryce Harrington

ppa: Add --enable/--disable options

These options control whether packages can be uploaded to the PPA for
building. The option names and descriptions are drawn from Launchpad's
name and description of the same feature for consistency.

fcda15e... by Bryce Harrington

Expand support for setting CPU architectures for PPA

Options --all-architectures and --default-architectures (and abbreviated
forms for convenience) are added for the two most common use cases:
"Give me everything" and "Just the usual", respectively.

Note that ppa create's default behavior corresponds with
--all-architectures, NOT --default-architectures. 'default' here refers
to _Launchpad_'s default behavior, not ppa-dev-tool's. It's felt that
current users of this CLI tool prefer all architectures to be enabled.

However, it's likely there are people who are satisfied with Launchpad's
default, so --default-architectures is added as a straightforward to
understand way of setting things up that way. Note that since all
command line arguments can be specified in the config file, this gives
users an effective way to locally change this default behavior to their
own druthers.

33134ce... by Bryce Harrington

create: Allow settings to be specified at creation time

Commit 3837ef8c states the intent for configuration settings to be
specified either at creation time or after. However that commit only
allowed the name and description. This commit modifies create() so it
can accept arbitrary settings, which are then passed directly to

428d58f... by Bryce Harrington

test_ppa_group: Drop extraneous description tests

These two tests no longer pass, but they're essentially just cosmetic
tests of description setting. There are no specifications as to how ppa
descriptions should be written, and no special support planned for the
tool around bug numbers.

3837ef8... by Bryce Harrington

Add ppa set command

The set and create commands will support the same set of
configuration settings, so this adds the set command and generalizes
some of the option handling for create to work for both.

For now this supports only the already existing displayname,
description, and architecture settings, but this establishes the
structure we'll slot all the other settings into subsequently.

01d9b53... by Bryce Harrington

ppa: For subparsers, don't add attributes if arg isn't present

Since we're now adding global arguments both at the top level and at the
subparser level, it's possible to cause the default to be set twice -
which can override options set at the top level (before the command)
with the subparser's post-command argument handler. Setting SUPPRESS on
the subparsers prevents this behavior.

Fixes the following failure found by the testsuite:

            # Check -D, --debug
            args = parser.parse_args(['-D', 'status', 'test-ppa'])
    > assert args.debug is True
    E AssertionError: assert False is True
    E + where False = Namespace(command='status', config_filename='~/.config/ppa-dev-tools/config.yml', debug=False, dry_run=False, ppa_name='test-ppa', quiet=False, verbose=False).debug

Note that a default value needs to be provided for --show-urls, else the
following test failure happens:

            # Check --show-urls, --show-url, -L
            args = parser.parse_args([command, 'tests-ppa'])
    > assert args.show_urls is False
    E AttributeError: 'Namespace' object has no attribute 'show_urls'

The --show-urls argument for the tests command uses action='store_true',
which includes automatic functionality to set the default value to the
opposite (False), however it appears that SUPPRESS interferes with this.