Merge lp:~brian-murray/ubuntu-dev-tools/fix-params into lp:~ubuntu-dev/ubuntu-dev-tools/trunk
Proposed by
Brian Murray
Status: | Rejected |
---|---|
Rejected by: | Mattia Rizzolo |
Proposed branch: | lp:~brian-murray/ubuntu-dev-tools/fix-params |
Merge into: | lp:~ubuntu-dev/ubuntu-dev-tools/trunk |
Diff against target: |
12 lines (+1/-1) 1 file modified
ubuntutools/lp/lpapicache.py (+1/-1) |
To merge this branch: | bzr merge lp:~brian-murray/ubuntu-dev-tools/fix-params |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stefano Rivera | Disapprove | ||
Review via email: mp+125786@code.launchpad.net |
Description of the change
Instead of this:
seeded-in-ubuntu: Error: The package 'update-
Report this:
seeded-in-ubuntu: Error: The source package 'update-
This is useful for figuring out that I was dumb and wanted to use the -b switch.
For some reason name_key was set to name which didn't really make sense to me.
To post a comment you must log in.
Unmerged revisions
- 1347. By Brian Murray
-
don't set name_key to the package name
I think you are misunderstanding the purpose of name_key. It's the name of the named parameter that will be the source/binary package name.
I don't see what this patch has to do with making seeded-in-ubuntu say "source package", either. That was already fixed in LP: #1029155