Code review comment for lp:~brian-murray/ubuntu-dev-tools/fix-params

Revision history for this message
Brian Murray (brian-murray) wrote :

I was looking at lines 371+, http://bazaar.launchpad.net/~ubuntu-dev/ubuntu-dev-tools/trunk/view/head:/ubuntutools/lp/lpapicache.py#L371, which show the following:

            if latest is None:
                if name_key == 'binary_name':
                    package_type = "binary package"
                elif name_key == 'source_name':
                    package_type = "source package"
                else:
                    package_type = "package"

Additionally, there is a named_key and name parameter passed to _getPublishedItem. seeded-in-ubuntu calls getSourcePackage which then calls _getPublishedItem with name_key='source_name' so I'm really pretty sure name_key should set to name_key in the parameters and not name.

« Back to merge proposal