Code review comment for lp:~brendan-donegan/ubuntu-autopilot-tests/bug1297295

Revision history for this message
Leo Arias (elopio) wrote :

I'm trying to understand why you are using the MainView as base class. I haven't found anything useful yet, but a couple of things:

86 +class MessagingAddressBookTestCase(messaging_tests.BaseMessagingTestCase):

Some of these tests will need to interact with unity, so we need to restart unity with testability. Currently, that's done telling jenkins to start without a shell. So on your test you will need to restart unity even if you are not interacting with unity. It might be a good idea to kill unity only if you need it, but I think it's good to start with a clean unity. What do you think?

Anyway, in order to run with the current jenkins job, you'll need to inherit from UbuntuExperienceTestCase.

In addition to that, it's probably a bad idea to inherit from that BaseMessagingTestCase. It's on the wrong file, because we should split that test_messaging.py in smaller suites that test the different parts of the app. I think that the right thing to do is to use Fixtures to set up the app environment you need instead of inherit from an app test case that's likely to change. Take a look at what omer is doing here:
https://code.launchpad.net/~om26er/messaging-app/use_fixture/+merge/225350

« Back to merge proposal