Merge lp:~brendan-donegan/ubuntu-autopilot-tests/bug1297295 into lp:ubuntu-autopilot-tests/ubuntu-experience-tests

[Brendan Donegan]

Add UX test for adding a number to a contact from an SMS message

[Leo Arias (elopio)]

Looks really nice. Just you have a lot of things to move to the messaging and address book apps. From your TODOs, I think you have that on your roadmap.

In the end, this tests should be nicely readable, just calling methods with names that represent user actions, like open_thread, or add_to_contacts

[Brendan Donegan (brendan-donegan)]

Thanks for the good feedback - yes my plan is to avoid any explicit calls to wait_select and so on in the test, so I will need to do some work in messaging-app and address-book-app. I'll ask for another review later when I've done that.

[Brendan Donegan (brendan-donegan)]

Followed up on most of the comments. The updates to messaging-app and address-book-app will take a bit longer.

[Leo Arias (elopio)]

contactsdb/main.cpp doesn't have tests. And this is not the right project for contacts helpers. Have you tried to merge them to the messaging app? Also, I would prefer the test helpers to be python, unless there's a good reason not to. Why did you chose cpp?

[Leo Arias (elopio)]

review: Needs Fixing

[Leo Arias (elopio)]

s/messaging app/address book

[lp:~brendan-donegan/ubuntu-autopilot-tests/bug1297295]

35. By Brendan Donegan on 2014-06-30

Removed contactsdb directory since it wasn't used

[Brendan Donegan (brendan-donegan)]

The contactsdb stuff is what I was writing before I realised there was a dbus service available for that. I removed it in my local branch but forgot to push it up. Deleted it now.

[lp:~brendan-donegan/ubuntu-autopilot-tests/bug1297295]

36. By Brendan Donegan on 2014-06-30

Tidy up comments

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:36
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~brendan-donegan/ubuntu-autopilot-tests/bug1297295/+merge/221342/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/7/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1430/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2385/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/7/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:36
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/14/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1584/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2581/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/14/rebuild

review: Needs Fixing (continuous-integration)

[lp:~brendan-donegan/ubuntu-autopilot-tests/bug1297295]

37. By Brendan Donegan on 2014-07-03

Added test_mtp_transfer.py

38. By Brendan Donegan on 2014-07-07

Cleaned flake8 errors

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:36
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/15/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1638
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/15
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/15
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1911
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2660
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2660/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9401

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/15/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:38
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/16/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1646
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/16
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/1921
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2669
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2669/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9412

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/16/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

You need to add messaging-app-autopilot to the dependencies. But that's py2, so we'll have to wait for the py3 branch to land.

review: Needs Fixing

[Leo Arias (elopio)]

I'm trying to understand why you are using the MainView as base class. I haven't found anything useful yet, but a couple of things:

86 +class MessagingAddressBookTestCase(messaging_tests.BaseMessagingTestCase):

Some of these tests will need to interact with unity, so we need to restart unity with testability. Currently, that's done telling jenkins to start without a shell. So on your test you will need to restart unity even if you are not interacting with unity. It might be a good idea to kill unity only if you need it, but I think it's good to start with a clean unity. What do you think?

Anyway, in order to run with the current jenkins job, you'll need to inherit from UbuntuExperienceTestCase.

In addition to that, it's probably a bad idea to inherit from that BaseMessagingTestCase. It's on the wrong file, because we should split that test_messaging.py in smaller suites that test the different parts of the app. I think that the right thing to do is to use Fixtures to set up the app environment you need instead of inherit from an app test case that's likely to change. Take a look at what omer is doing here:
https://code.launchpad.net/~om26er/messaging-app/use_fixture/+merge/225350

[Leo Arias (elopio)]

ahhh, I get it. Wow, it took me a long time.

108 + address_book = helpers.get_proxy_object_by_process_name(
109 + 'address-book-app'
110 + )

There what you are getting is an autopilot proxy object, that's like one level higher than the root of the QML tree. So with that proxy object you have access to the full tree.
So, what you should do is something like this

import address_book_app

[...]

address_book_proxy_object = helpers.get_proxy_object_by_process_name(...)
address_book = address_book_app.AddressBookApp(address_book_proxy_object)
address_book.main_view.contact_view_page.save()

So, please remove the _get_emulator_base method, and just hardcode the toolkit base class there.

[lp:~brendan-donegan/ubuntu-autopilot-tests/bug1297295]

39. By Brendan Donegan on 2014-07-09

Merged from trunk

40. By Brendan Donegan on 2014-07-09

Use toolkit base class to get proxy object, and fix the expected result of the test.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:40
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/19/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1747
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/19
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2008
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2803
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2803/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9532

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/19/rebuild

review: Needs Fixing (continuous-integration)

[lp:~brendan-donegan/ubuntu-autopilot-tests/bug1297295]

41. By Brendan Donegan on 2014-07-09

Use TestabilityEnvironment from this project

42. By Brendan Donegan on 2014-07-16

Use messaging fixture and UbuntuExperienceTestCase

43. By Brendan Donegan on 2014-07-16

Remove accidently added mtp test code

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:43
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/26/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2231/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/26/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/26/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/26/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3413/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/26/rebuild

review: Needs Fixing (continuous-integration)

[lp:~brendan-donegan/ubuntu-autopilot-tests/bug1297295]

44. By Brendan Donegan on 2014-07-24

Update to use new helpers which will be in address-book-app and fix imports

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:44
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/29/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2426/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/29/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/29/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/29/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3658/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/29/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

44. By Brendan Donegan on 2014-07-24

Update to use new helpers which will be in address-book-app and fix imports

43. By Brendan Donegan on 2014-07-16

Remove accidently added mtp test code

42. By Brendan Donegan on 2014-07-16

Use messaging fixture and UbuntuExperienceTestCase

41. By Brendan Donegan on 2014-07-09

Use TestabilityEnvironment from this project

40. By Brendan Donegan on 2014-07-09

Use toolkit base class to get proxy object, and fix the expected result of the test.

39. By Brendan Donegan on 2014-07-09

Merged from trunk

38. By Brendan Donegan on 2014-07-07

Cleaned flake8 errors

37. By Brendan Donegan on 2014-07-03

Added test_mtp_transfer.py

36. By Brendan Donegan on 2014-06-30

Tidy up comments

35. By Brendan Donegan on 2014-06-30

Removed contactsdb directory since it wasn't used

=== modified file 'ubuntu_experience_tests/helpers.py'
--- ubuntu_experience_tests/helpers.py	2014-06-19 17:46:15 +0000
+++ ubuntu_experience_tests/helpers.py	2014-07-24 09:16:04 +0000
@@ -83,6 +83,20 @@
             uid = match.group(1)
         return uid
 
+    def get_vcard_cell(self, vcard):
+        """
+        Return the mobile number of the provided vcard
+        :param vcard: vcard formatted data
+        :return: mobile number from vcard, else None
+        """
+        cell_pattern = re.compile(r'^.*TYPE=CELL,HOME:(?P<cell>\S*)\r?$',
+                                  re.MULTILINE | re.IGNORECASE)
+        cell = None
+        match = cell_pattern.search(vcard)
+        if match:
+            cell = match.group('cell')
+        return cell
+
     def delete_all_contacts(self):
         """
         Delete all contacts using the dbus service

=== added directory 'ubuntu_experience_tests/tests/messaging_app'
=== added file 'ubuntu_experience_tests/tests/messaging_app/__init__.py'
=== added file 'ubuntu_experience_tests/tests/messaging_app/test_messaging_app.py'
--- ubuntu_experience_tests/tests/messaging_app/test_messaging_app.py	1970-01-01 00:00:00 +0000
+++ ubuntu_experience_tests/tests/messaging_app/test_messaging_app.py	2014-07-24 09:16:04 +0000
@@ -0,0 +1,75 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+#
+# Copyright 2014 Canonical Ltd.
+# Author: Brendan Donegan <[e-mail]>
+#
+# This file is part of ubuntu-experience-tests.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>
+import address_book_app
+import os
+import time
+
+from messaging_app import helpers as messaging_helpers
+from messaging_app import fixture_setup as messaging_fixtures
+from ubuntu_experience_tests import helpers as ux_helpers
+from ubuntu_experience_tests import fixture_setup as ux_fixtures
+from ubuntu_experience_tests.tests import UbuntuExperienceTestCase
+
+CONTACT_NAME = 'Ubuntu'
+CONTACT_NUMBER = '800800'
+MESSAGE_BODY = 'Ubuntu Touch'
+
+CONTACT_VCARD = """
+BEGIN:VCARD
+VERSION:3.0
+N:%s
+END:VCARD
+""" % CONTACT_NAME
+
+
+class MessagingAddressBookTestCase(UbuntuExperienceTestCase):
+
+    def setUp(self):
+        super(UbuntuExperienceTestCase, self).setUp()
+        self.useFixture(ux_fixtures.TestabilityEnvironment())
+        self.useFixture(messaging_fixtures.MessagingTestEnvironment())
+        self.contacts_service = ux_helpers.ContactsDbusService()
+        self.test_contact = self.contacts_service.create_contact(CONTACT_VCARD)
+        self.addCleanup(self.contacts_service.delete_contact,
+                        [self.contacts_service.get_vcard_uid(
+                            self.test_contact)])
+
+    def test_add_phone_number_to_contact_from_message(self):
+        messaging_helpers.receive_sms(CONTACT_NUMBER, MESSAGE_BODY)
+        main = self.main_view.get_main_page()
+        main.open_thread('800800')
+        # Workaround the message notification covering the toolbar
+        time.sleep(5)
+        self.main_view.click_add_button()
+        address_book_proxy = helpers.get_proxy_object_by_process_name(
+            'address-book-app'
+        )
+        self.addCleanup(os.system, 'ubuntu-app-stop address-book-app')
+        #contact = self.main_view.wait_select_single('Label', text='Ubuntu')
+        #self.app.pointing_device.click_object(contact)
+        address_book = address_book_app.AddressBookApp(address_book_proxy)
+        list_page = address_book.main_window.get_contact_list_page()
+        edit_page = list_page.open_contact(0)
+        # Save the contact
+        address_book.main_window.save()
+        # Verify that the number was saved in the contact
+        updated_contact = self.contacts_service.query_contacts(
+            'uid', self.contacts_service.get_vcard_uid(self.test_contact))[0]
+        self.assertEquals(self.contacts_service.get_vcard_cell(
+            updated_contact), '800800')