Code review comment for lp:~bratsche/libdbusmenu/remove-warning

Revision history for this message
Ted Gould (ted) wrote :

  review approve

On Wed, 2010-03-24 at 01:05 +0000, Cody Russell wrote:
> Cody Russell has proposed merging lp:~bratsche/dbusmenu/remove-warning into lp:dbusmenu.
>
> Requested reviews:
> DBus Menu Team (dbusmenu-team)
> Related bugs:
> #534854 indicator-applet logs 'GTK not updated' to disk every 30 seconds
> https://bugs.launchpad.net/bugs/534854
>
> differences between files attachment (review-diff.txt)
> === modified file 'libdbusmenu-gtk/client.c'
> --- libdbusmenu-gtk/client.c 2010-02-04 18:56:49 +0000
> +++ libdbusmenu-gtk/client.c 2010-03-24 01:05:26 +0000
> @@ -411,7 +411,6 @@
>
> gpointer data = g_object_get_data(G_OBJECT(item), data_menuitem);
> if (data == NULL) {
> - g_warning("GTK not updated");
> return NULL;
> }
>
>

review: Approve

« Back to merge proposal