DBus Menu

Merge lp:~bratsche/libdbusmenu/remove-warning into lp:libdbusmenu/0.5

  1. remove-warning
  2. Merge into trunk
Proposed by Cody Russell
Status: Merged
Merged at revision: not available
Proposed branch: lp:~bratsche/libdbusmenu/remove-warning
Merge into: lp:libdbusmenu/0.5
Diff against target: 10 lines (+0/-1)
1 file modified
libdbusmenu-gtk/client.c (+0/-1)
To merge this branch: bzr merge lp:~bratsche/libdbusmenu/remove-warning
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+21999@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

  review approve

On Wed, 2010-03-24 at 01:05 +0000, Cody Russell wrote:
> Cody Russell has proposed merging lp:~bratsche/dbusmenu/remove-warning into lp:dbusmenu.
>
> Requested reviews:
> DBus Menu Team (dbusmenu-team)
> Related bugs:
> #534854 indicator-applet logs 'GTK not updated' to disk every 30 seconds
> https://bugs.launchpad.net/bugs/534854
>
> differences between files attachment (review-diff.txt)
> === modified file 'libdbusmenu-gtk/client.c'
> --- libdbusmenu-gtk/client.c 2010-02-04 18:56:49 +0000
> +++ libdbusmenu-gtk/client.c 2010-03-24 01:05:26 +0000
> @@ -411,7 +411,6 @@
>
> gpointer data = g_object_get_data(G_OBJECT(item), data_menuitem);
> if (data == NULL) {
> - g_warning("GTK not updated");
> return NULL;
> }
>
>

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-gtk/client.c'
2--- libdbusmenu-gtk/client.c 2010-02-04 18:56:49 +0000
3+++ libdbusmenu-gtk/client.c 2010-03-24 01:05:26 +0000
4@@ -411,7 +411,6 @@
5
6 gpointer data = g_object_get_data(G_OBJECT(item), data_menuitem);
7 if (data == NULL) {
8- g_warning("GTK not updated");
9 return NULL;
10 }
11

Subscribers

People subscribed via source and target branches