Code review comment for lp:~brandontschaefer/unity/switcher-alt+f4-fix

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

Hi,

171 + self.keyboard.press_and_release("Alt+F4")
172 + [win] = [w for w in app.get_windows()]
173 +
174 + self.assertThat(win.is_valid, Equals(True))

This will also pass even if the code is broken and we run it on the jenkins machine. It's a bit ugly, but I'd like to see a "sleep(10)" just before the assert, with a comment saying why we need it.

Otherwise looks good to me.

Cheers

review: Needs Fixing (quality)

« Back to merge proposal