Merge lp:~brandontschaefer/unity/switcher-alt+f4-fix into lp:unity
Proposed by
Brandon Schaefer
Status: | Merged |
---|---|
Approved by: | Brandon Schaefer |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2441 |
Proposed branch: | lp:~brandontschaefer/unity/switcher-alt+f4-fix |
Merge into: | lp:unity |
Diff against target: |
202 lines (+69/-4) 7 files modified
launcher/SwitcherController.cpp (+13/-0) launcher/SwitcherController.h (+2/-0) launcher/SwitcherModel.cpp (+1/-1) plugins/unityshell/src/unityshell.cpp (+27/-0) plugins/unityshell/src/unityshell.h (+5/-0) tests/autopilot/unity/tests/test_switcher.py (+18/-2) unity-shared/UBusMessages.h (+3/-1) |
To merge this branch: | bzr merge lp:~brandontschaefer/unity/switcher-alt+f4-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andrea Azzarone (community) | Approve | ||
Thomi Richards (community) | quality | Approve | |
Review via email: mp+111703@code.launchpad.net |
Commit message
The switcher now focuses it's own window, instead of leaving it to the current one. Now Alt+F4 does not work while the switcher is active.
Description of the change
=== Problem ===
When the switcher starts it does not take the focus from the current window. This means if you press Alt+F4 it will close that program, but when you exit from the switcher it will restart that application.
=== Fix ===
The fix is to take the switchers view window and give it focus. If the switcher is cancled then restore focus to the previous window. Else, do what the switcher normally does.
=== Test ===
AP test included.
To post a comment you must log in.
All switcher AP test pass locally.
Ran 24 tests in 185.487s
OK (skipped=1)