Merge ~blake-rouse/maas:fix-1801389 into maas:master
Proposed by
Blake Rouse
Status: | Merged |
---|---|
Approved by: | Blake Rouse |
Approved revision: | 4e15fb66122a591d6dea99e42adfaad52917fdc7 |
Merge reported by: | MAAS Lander |
Merged at revision: | not available |
Proposed branch: | ~blake-rouse/maas:fix-1801389 |
Merge into: | maas:master |
Diff against target: |
128 lines (+79/-2) 3 files modified
src/provisioningserver/logger/__init__.py (+5/-1) src/provisioningserver/logger/_logging.py (+1/-1) src/provisioningserver/logger/_maaslog.py (+73/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mike Pontillo (community) | Approve | ||
Review via email: mp+358935@code.launchpad.net |
Commit message
Fixes LP: #1801389 - Queue messages to syslog until the logging handler can actually connect.
Description of the change
I spent too much time trying to unit test this handler. Upstream python tests it against a running syslog if available, but this would dirty the system running the unit tests so I didn't like that approach.
I could setup a syslog just to test this one test, but that just seems way overkill for something as simple as queue messages.
I have tested this running and it works correctly, no more stack trace and the messages get queued and wrote to the socket.
To post a comment you must log in.
Code looks good; good comments. Just a few grammar nits below.