Merge lp:~bladernr/checkbox-certification/cert-add-cert-whitelist into lp:checkbox-certification

[Jeff Lane ]

Certification Whitelist In tha HOUSE.

[Marc Tardif (cr3)]

Any particular reason why the acpi_sleep job was renamed to acpi_sleep_attachment? For example, was it conflicting with another job?

review: Needs Information

[Jeff Lane  (bladernr)]

On 02/02/2011 12:18 PM, Marc Tardif wrote:
> Review: Needs Information
> Any particular reason why the acpi_sleep job was renamed to acpi_sleep_attachment? For example, was it conflicting with another job?

actually, I forgot to change the rest of them...

That one was changed for consistency sake, since I also changed all the
attachment jobs in base to *_attach I meant to change all the ones in
-cert to match. I failed that bit of consistency as it was a last
minute addition while playing with the whitelist...

It does not currently conflict with any actual test job, however, who
knows what could happen in the future... I found conflicts in base,
which prompted the renaming...

--
Jeff Lane - Hardware Certification Engineer and Test Tools Developer
Ubuntu Ham: W4KDH
Freenode IRC: bladernr or bladernr_
gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD

[lp:~bladernr/checkbox-certification/cert-add-cert-whitelist]

325. By Jeff Lane  on 2011-02-02

Created seperate whitelists for client and server certification

[Marc Tardif (cr3)]

Looks good and took the opportunity to rename a few jobs:

sru_attach_screenshot -> sru_screenshot_attachment
sru_xorg-failsafe -> sru_xorg_failsafe
sru_xorg-process -> sru_xorg_process
sru_fwts-wakealarm -> sru_fwts_wakealarm

And made sure to update the whitelists accordingly.

review: Approve

=== modified file 'jobs/certification.txt'
--- jobs/certification.txt	2011-01-12 21:19:16 +0000
+++ jobs/certification.txt	2011-02-02 20:04:26 +0000
@@ -4,7 +4,7 @@
 description: Certification tests.
 
 plugin: attachment
-name: acpi_sleep
+name: acpi_sleep_attachment
 command: cat /proc/acpi/sleep
 
 plugin: local
 
=== modified file 'jobs/cpu.txt'
--- jobs/cpu.txt	2010-08-27 22:30:33 +0000
+++ jobs/cpu.txt	2011-02-02 20:04:26 +0000
@@ -1,10 +1,12 @@
 plugin: shell
 name: cpu_scaling_test
-requires: package.name == 'linux'
+requires: 
+ package.name == 'linux'
+ package.name == 'fwts'
 user: root
-command: cpu_scaling_test
+command: fwts_test -c -l $CHECKBOX_DATA/cpu_scaling_test.log
 description:
- Test the CPU scaling capabilities.
+ Test the CPU scaling capabilities using Colin King's Firmware Test Suite tool.
 
 plugin: shell
 name: clocktest
 
=== modified file 'jobs/hardware.txt'
--- jobs/hardware.txt	2010-12-03 22:38:58 +0000
+++ jobs/hardware.txt	2011-02-02 20:04:26 +0000
@@ -14,7 +14,7 @@
 description:
  Run Colin King's Firmware Test Suite automated tests.
 command:
- fwts_test -l $CHECKBOX_CERTIFICATION_SHARE/fwts_results.log
+ fwts_test -l $CHECKBOX_DATA/fwts_results.log
 
 plugin: attachment
 name: fwts_log
@@ -22,4 +22,4 @@
 description:
  Gather log from the firmware test suite run
 command:
- cat $CHECKBOX_CERTIFICATION_SHARE/fwts_results.log
+ cat $CHECKBOX_DATA/fwts_results.log
 
=== modified file 'jobs/kernel.txt'
--- jobs/kernel.txt	2010-12-03 22:38:58 +0000
+++ jobs/kernel.txt	2011-02-02 20:04:26 +0000
@@ -1,10 +1,10 @@
 plugin: shell
-name: fwts-wakealarm
+name: fwts_wakealarm
 description: Run Colin Kings FWTS wakealarm test
 requires:
  package.name == 'linux'
  package.name == 'fwts'
-command: fwts_test -w -l $CHECKBOX_CERTIFICATION_SHARE/fwts-wakealarm.log
+command: fwts_test -w -l $CHECKBOX_DATA/fwts-wakealarm.log
 
 plugin: shell
 name: tickless_idle_test
 
=== modified file 'jobs/sru_suite.txt'
--- jobs/sru_suite.txt	2011-01-31 15:54:46 +0000
+++ jobs/sru_suite.txt	2011-02-02 20:04:26 +0000
@@ -78,7 +78,7 @@
  package.name == 'linux'
  package.name == 'fwts'
 user: root
-command: fwts_test -c -l $CHECKBOX_CERTIFICATION_SHARE/fwts_results.log
+command: fwts_test -c -l $CHECKBOX_DATA/fwts_results.log
 description:
  Test the CPU scaling capabilities.
 
@@ -90,7 +90,7 @@
 description:
  Run Colin King's FWTS wakealarm test
 command:
- fwts_test -w -l $CHECKBOX_CERTIFICATION_SHARE/fwts_results.log
+ fwts_test -w -l $CHECKBOX_DATA/fwts_results.log
 
 plugin: shell
 name: sru_tickless_idle_test