Code review comment for lp:~bladernr/checkbox-certification/cert-add-cert-whitelist

On 02/02/2011 12:18 PM, Marc Tardif wrote:
> Review: Needs Information
> Any particular reason why the acpi_sleep job was renamed to acpi_sleep_attachment? For example, was it conflicting with another job?

actually, I forgot to change the rest of them...

That one was changed for consistency sake, since I also changed all the
attachment jobs in base to *_attach I meant to change all the ones in
-cert to match. I failed that bit of consistency as it was a last
minute addition while playing with the whitelist...

It does not currently conflict with any actual test job, however, who
knows what could happen in the future... I found conflicts in base,
which prompted the renaming...

--
Jeff Lane - Hardware Certification Engineer and Test Tools Developer
Ubuntu Ham: W4KDH
Freenode IRC: bladernr or bladernr_
gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD