Benjamin, You didn't need to delete the first merge proposal. You only needed to make the changes I suggested, and push and as for a new review. Per my first review:
Open lib/lp/registry/browser/tests/test_team.py and paste this test at the end of TestTeamEditView
def test_expiration_and_renewal(self):
# The team's membership expiration and renewal rules can be set.
owner = self.factory.makePerson()
team = self.factory.makeTeam(name="team", owner=owner)
form = { 'field.name': team.name, 'field.displayname': team.displayname, 'field.defaultmembershipperiod': '180', 'field.defaultrenewalperiod': '365', 'field.membership_policy': 'RESTRICTED', 'field.renewal_policy': 'ONDEMAND', 'field.actions.save': 'Save',
} login_person(owner)
view = create_initialized_view(team, '+edit', form=form) self.assertEqual(0, len(view.errors)) self.assertEqual( TeamMembershipPolicy.RESTRICTED, team.membership_policy) self.assertEqual(180, team.defaultmembershipperiod) self.assertEqual(365, team.defaultrenewalperiod) self.assertEqual( TeamMembershipRenewalPolicy.ONDEMAND, team.renewal_policy)
^ This test failed like the screenshot. Your widget fix should permit this test to pass.
After your commit, run
make lint
To verify your changes are clean and maintainable.
Benjamin, You didn't need to delete the first merge proposal. You only needed to make the changes I suggested, and push and as for a new review. Per my first review:
Open lib/lp/ registry/ browser/ tests/test_ team.py and paste this test at the end of TestTeamEditView
def test_expiration _and_renewal( self): makePerson( ) makeTeam( name="team" , owner=owner)
'field. name': team.name,
'field. displayname' : team.displayname,
'field. defaultmembersh ipperiod' : '180',
'field. defaultrenewalp eriod': '365',
'field. membership_ policy' : 'RESTRICTED',
'field. renewal_ policy' : 'ONDEMAND',
'field. actions. save': 'Save',
login_ person( owner) initialized_ view(team, '+edit', form=form)
self.assertEqu al(0, len(view.errors))
self.assertEqu al(
TeamMember shipPolicy. RESTRICTED, team.membership _policy)
self.assertEqu al(180, team.defaultmem bershipperiod)
self.assertEqu al(365, team.defaultren ewalperiod)
self.assertEqu al(
TeamMember shipRenewalPoli cy.ONDEMAND, team.renewal_ policy)
# The team's membership expiration and renewal rules can be set.
owner = self.factory.
team = self.factory.
form = {
}
view = create_
^ This test failed like the screenshot. Your widget fix should permit this test to pass.
After your commit, run
make lint
To verify your changes are clean and maintainable.