Merge lp:~bkerensa/launchpad/fix-for-1044457 into lp:launchpad

[Benjamin Kerensa]

Changed TeamEditView to IntWidget

Changed TeamEditView to IntWidget

[Steve Kowalik (stevenk)]

Hi Benjamin,

This looks like great work, except that Launchpad has a policy that every code change has test coverage, and it's clear from the previous MP for this branch that it does not. I would suggest making use of the test that Curtis Hovey linked in the previous review.

This branch also introduces an unused import, since lib/lp/registry/browser/team.py no longer makes use of StrippedTextWidget.

review: Needs Fixing (code)

[Curtis Hovey (sinzui)]

Benjamin, You didn't need to delete the first merge proposal. You only needed to make the changes I suggested, and push and as for a new review. Per my first review:

Open lib/lp/registry/browser/tests/test_team.py and paste this test at the end of TestTeamEditView

    def test_expiration_and_renewal(self):
        # The team's membership expiration and renewal rules can be set.
        owner = self.factory.makePerson()
        team = self.factory.makeTeam(name="team", owner=owner)
        form = {
            'field.name': team.name,
            'field.displayname': team.displayname,
            'field.defaultmembershipperiod': '180',
            'field.defaultrenewalperiod': '365',
            'field.membership_policy': 'RESTRICTED',
            'field.renewal_policy': 'ONDEMAND',
            'field.actions.save': 'Save',
            }
        login_person(owner)
        view = create_initialized_view(team, '+edit', form=form)
        self.assertEqual(0, len(view.errors))
        self.assertEqual(
            TeamMembershipPolicy.RESTRICTED, team.membership_policy)
        self.assertEqual(180, team.defaultmembershipperiod)
        self.assertEqual(365, team.defaultrenewalperiod)
        self.assertEqual(
            TeamMembershipRenewalPolicy.ONDEMAND, team.renewal_policy)

^ This test failed like the screenshot. Your widget fix should permit this test to pass.
After your commit, run

    make lint

To verify your changes are clean and maintainable.

[Curtis Hovey (sinzui)]

Benjamin, also per my first email, you can run the test case this way.
    ./bin/test -vvc -t TestTeamEditView lp.registry.browser.tests.test_team

Unmerged revisions

15898. By Benjamin Kerensa on 2012-09-03

Changed TeamEditView Custom Widget to IntWidget

=== modified file 'lib/lp/registry/browser/team.py'
--- lib/lp/registry/browser/team.py	2012-08-15 22:01:39 +0000
+++ lib/lp/registry/browser/team.py	2012-09-03 05:11:21 +0000
@@ -299,7 +299,7 @@
 
     custom_widget(
         'renewal_policy', LaunchpadRadioWidget, orientation='vertical')
-    custom_widget('defaultrenewalperiod', StrippedTextWidget,
+    custom_widget('defaultrenewalperiod', IntWidget,
         widget_class='field subordinate')
     custom_widget(
         'membership_policy', LaunchpadRadioWidgetWithDescription,