Merge lp:~bkerensa/landscape-client/trunk into lp:~landscape/landscape-client/trunk

Proposed by Benjamin Kerensa
Status: Rejected
Rejected by: Dean Henrichsmeyer
Proposed branch: lp:~bkerensa/landscape-client/trunk
Merge into: lp:~landscape/landscape-client/trunk
Diff against target: 44 lines (+15/-2)
3 files modified
applications/landscape-client-settings.desktop.in (+1/-1)
debian/changelog (+13/-0)
landscape/broker/config.py (+1/-1)
To merge this branch: bzr merge lp:~bkerensa/landscape-client/trunk
Reviewer Review Type Date Requested Status
Dean Henrichsmeyer (community) Disapprove
Barry Warsaw Pending
Review via email: mp+106921@code.launchpad.net

Description of the change

* Adjust name in System Settings UI to better reflect nature of application and be less ambiguous

To post a comment you must log in.
lp:~bkerensa/landscape-client/trunk updated
565. By Benjamin Kerensa

Polished Registration Key Name

Revision history for this message
Dean Henrichsmeyer (dean) wrote :

This branch doesn't just include a fix related to #1001468, it incorporates changes related to #962974. Please keep branches related to a single bug when they're not related.

review: Disapprove

Unmerged revisions

565. By Benjamin Kerensa

Polished Registration Key Name

564. By Benjamin Kerensa

Adjusted Name in UI

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'applications/landscape-client-settings.desktop.in'
--- applications/landscape-client-settings.desktop.in 2012-03-23 10:04:18 +0000
+++ applications/landscape-client-settings.desktop.in 2012-05-23 01:01:18 +0000
@@ -1,5 +1,5 @@
1[Desktop Entry]1[Desktop Entry]
2_Name=Management Service2_Name=Landscape Administration
3_Comment=Management Service Preferences3_Comment=Management Service Preferences
4Exec=landscape-client-ui-install4Exec=landscape-client-ui-install
5Icon=preferences-management-service5Icon=preferences-management-service
66
=== modified file 'debian/changelog'
--- debian/changelog 2012-03-28 17:06:17 +0000
+++ debian/changelog 2012-05-23 01:01:18 +0000
@@ -1,3 +1,16 @@
1landscape-client (12.04.3-0ubuntu0.12.04.2) quantal; urgency=low
2
3
4 * Polish Registration Key Name (LP: #1001468)
5
6 -- Benjamin Kerensa <bkerensa@ubuntu.com> Tue, 22 May 2012 17:56:55 -0700
7
8landscape-client (12.04.3-0ubuntu0.12.04.1) quantal; urgency=low
9
10 * Adjust name reflected in UI (LP: #962974)
11
12 -- Benjamin Kerensa <bkerensa@ubuntu.com> Tue, 22 May 2012 17:36:54 -0700
13
1landscape-client (12.04.3-0ubuntu0.12.04.0) precise; urgency=low14landscape-client (12.04.3-0ubuntu0.12.04.0) precise; urgency=low
215
3 * Warn on unicode entry into settings UI (LP: #956612).16 * Warn on unicode entry into settings UI (LP: #956612).
417
=== modified file 'landscape/broker/config.py'
--- landscape/broker/config.py 2012-05-11 21:56:37 +0000
+++ landscape/broker/config.py 2012-05-23 01:01:18 +0000
@@ -40,7 +40,7 @@
4040
41 parser.add_option("-a", "--account-name", metavar="NAME",41 parser.add_option("-a", "--account-name", metavar="NAME",
42 help="The account this computer belongs to.")42 help="The account this computer belongs to.")
43 parser.add_option("-p", "--registration-key", metavar="PASSWORD",43 parser.add_option("-p", "--registration-key", metavar="KEY",
44 help="The account-wide key used for "44 help="The account-wide key used for "
45 "registering clients.")45 "registering clients.")
46 parser.add_option("-t", "--computer-title", metavar="TITLE",46 parser.add_option("-t", "--computer-title", metavar="TITLE",

Subscribers

People subscribed via source and target branches

to all changes: