Code review comment for lp:~bkbox/ubuntu/maverick/munin/fix-for-699967

Revision history for this message
Artur Rona (ari-tczew) wrote :

Thank you for your time and efforts making Ubuntu better! However, there are some issues:

1) I'd like to see improved entry in debian/changelog, so I encourage to:
  * debian/patches/upstream_bug_952.patch:
    - Fix empty list of plugins/services. (LP: #699967)

2) Please add DEP3 tags.
https://wiki.ubuntu.com/PackagingGuide/PatchSystems#Patch%20Tagging%20Guidelines

review: Needs Fixing

« Back to merge proposal