Empty list of plugins/services with hostname containing uppercase letters

Bug #699967 reported by Daniel Hahler
22
This bug affects 2 people
Affects Status Importance Assigned to Milestone
munin
Fix Released
Unknown
munin (Debian)
Fix Released
Unknown
munin (Ubuntu)
Fix Released
Medium
Unassigned
Maverick
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: munin

I've upgraded my munin-node instance on my OpenVZ hardware node to 1.4.5-1 from Debian testing, but this caused the list of services to be empty (via "telnet localhost 4949", then "list").

Downgrading to 1.4.4-1~blueyedppa2 (basically a backport of 1.4.4-1 from Debian).

There are plugins installed (quite a lot), and I can run them manually using munin-run.

TEST CASE:

Install a new machine with uppercase letters in the hostname (Maverick.example.com) and install munin-node then run the following commands:
# telnet localhost 4949
> nodes
> list Maverick.example.com

or run

# su - munin --shell=/bin/bash -c munin-cron

Related branches

Daniel Hahler (blueyed)
Changed in munin (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Daniel Hahler (blueyed)
summary: - Empty list of plugins/services (case issue)
+ Empty list of plugins/services with hostname containing uppercase
+ letters
Changed in munin:
status: Unknown → Fix Released
Changed in munin (Debian):
status: Unknown → Confirmed
Daniel Hahler (blueyed)
Changed in munin (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Daniel Hahler (blueyed)
Revision history for this message
Daniel Hahler (blueyed) wrote :

Package is waiting for sponsorship:
http://codeprobe.de/spool/debian/munin_1.4.5-3ubuntu2.dsc

I have asked Chuck (zul) on IRC - will subscribe sponsors in case this does not work out.

Revision history for this message
Daniel Hahler (blueyed) wrote :

Subscribing ubuntu-sponsors. I hope it's OK to have the package linked like that.
Otherwise I might push a branch tonight.

Changed in munin (Ubuntu):
status: In Progress → Triaged
assignee: Daniel Hahler (blueyed) → nobody
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Thanks for looking into this.

Could you please either attach a debdiff to this bug, or push a branch?

Thanks.

Revision history for this message
Daniel Hahler (blueyed) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package munin - 1.4.5-3ubuntu2

---------------
munin (1.4.5-3ubuntu2) natty; urgency=low

  * Add debian/patches/upstream_bug_952.patch (LP: #699967) to fix empty list
    of plugins/services
  * Add "timeout" to list of legal config keywords, allowing to configure it
    for munin-update in munin.conf.
    - Upstream bug: http://munin-monitoring.org/ticket/1021
    - Patch: debian/patches/upstream_add-timeout-to-legal-options.patch
  * Fix ignoring of pid_file from config
    - Upstream bug: http://munin-monitoring.org/ticket/975 (fixed for 1.4.6)
    - Patch: debian/patches/upstream_bug-975-fixed-in-1.4.6.patch
 -- Daniel Hahler <email address hidden> Thu, 27 Jan 2011 00:36:44 +0100

Changed in munin (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
BK Box (bkbox) wrote :

Was this only pushed to Natty? This issue is also present in Maverick, can we get it pushed out there as well?

Revision history for this message
Daniel Hahler (blueyed) wrote :

This would require a Stable Release Update.
Please refer to the documentation at https://wiki.ubuntu.com/SRU about how to proceed regarding this.

Revision history for this message
BK Box (bkbox) wrote :

SRU: minimal patch for Maverick has been submitted in bzr

Nominating for SRU, fulfills: (1) have an obviously safe patch and (2) affect an application rather than critical infrastructure packages

The fix is from upstream and has been verified in Natty.

description: updated
Revision history for this message
Daniel Hahler (blueyed) wrote :

Regarding the SRU for Maverick:
The following issues have been found by ari-tczew looking at the patch (#ubuntu-motu):
 - debian/changelog should have maverick-proposed as pocket instead of maverick
 - you are patching node/lib/Munin/Node/Server.pm directly, instead of using the patch system (where you are referring to upstream_bug_952.patch, but not including it). Please add the patch instead of patching the source directly.

Revision history for this message
Kees Cook (kees) wrote :

This has been uploaded to -proposed. Once it has built, please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Thank you in advance!

Changed in munin (Ubuntu Maverick):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted munin into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message
BK Box (bkbox) wrote :

Installed from -proposed and works great for me.

tags: added: verification-done
removed: verification-needed
Changed in munin (Debian):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package munin - 1.4.5-1ubuntu2.1

---------------
munin (1.4.5-1ubuntu2.1) maverick-proposed; urgency=low

  * debian/patches/upstream_bug_952.patch:
    - Fix empty list of plugins/services (LP: #699967)
      Patch is backported from natty
 -- BK Box <email address hidden> Tue, 08 Feb 2011 14:22:37 -0600

Changed in munin (Ubuntu Maverick):
status: Fix Committed → Fix Released
Changed in munin (Debian):
status: Fix Committed → Fix Released
tags: added: testcase
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.