Merge ~bjornt/maas:region-ip-not-valid into maas:master

[Björn Tillenius]

Bug #2054377: Temporal worker pool configuration failure

In the configure workflow, the query for getting the region IPs
included None values, which broke the workflow.

Changed the query not to include any None values.

[Adam Collard (adam-collard)]

review: Approve

[Anton Troyanov (troyanov)]

review: Approve

[MAAS Lander (maas-lander)]

UNIT TESTS
-b region-ip-not-valid lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas-tester/4674/console
COMMIT: 2faa6ef12b2d6fd5f72282c026a417cd42150085

review: Needs Fixing

diff --git a/src/maasserver/workflow/configure.py b/src/maasserver/workflow/configure.py
index a767371..59db1c6 100644
--- a/src/maasserver/workflow/configure.py
+++ b/src/maasserver/workflow/configure.py
@@ -103,29 +103,24 @@ class ConfigureAgentActivity(ActivityBase):
                 .join(
                     NodeConfigTable,
                     NodeTable.c.current_config_id == NodeConfigTable.c.id,
-                    isouter=True,
                 )
                 .join(
                     InterfaceTable,
                     NodeConfigTable.c.id == InterfaceTable.c.node_config_id,
-                    isouter=True,
                 )
                 .join(
                     InterfaceIPAddressTable,
                     InterfaceTable.c.id
                     == InterfaceIPAddressTable.c.interface_id,
-                    isouter=True,
                 )
                 .join(
                     StaticIPAddressTable,
                     InterfaceIPAddressTable.c.staticipaddress_id
                     == StaticIPAddressTable.c.id,
-                    isouter=True,
                 )
                 .join(
                     SubnetTable,
                     SubnetTable.c.id == StaticIPAddressTable.c.subnet_id,
-                    isouter=True,
                 )
                 .filter(
                     or_(
diff --git a/src/tests/fixtures/factories/node_config.py b/src/tests/fixtures/factories/node_config.py
index d44f777..1203241 100644
--- a/src/tests/fixtures/factories/node_config.py
+++ b/src/tests/fixtures/factories/node_config.py
@@ -41,5 +41,6 @@ async def create_test_node_config_entry(
             )
         )
         await fixture.conn.execute(stmt)
+        node["current_config_id"] = created_config["id"]
 
     return created_config
diff --git a/src/tests/maasserver/workflow/test_configure.py b/src/tests/maasserver/workflow/test_configure.py
index 8520848..2bd9f85 100644
--- a/src/tests/maasserver/workflow/test_configure.py
+++ b/src/tests/maasserver/workflow/test_configure.py
@@ -156,6 +156,35 @@ class TestConfigureAgentActivity:
             }
         ]
 
+    async def test_get_region_controller_endpoints_missing_links(
+        self, db: Database, db_connection: AsyncConnection, fixture: Fixture
+    ):
+        subnet = await create_test_subnet_entry(fixture)
+        region_controller = await create_test_region_controller_entry(fixture)
+        ip = await create_test_staticipaddress_entry(fixture, subnet=subnet)
+        await create_test_interface_entry(
+            fixture, node=region_controller, ips=[ip]
+        )
+        await create_test_interface_entry(
+            fixture, node=region_controller, ips=[]
+        )
+        configure_activities = ConfigureAgentActivity(
+            db, connection=db_connection
+        )
+
+        result = await configure_activities.get_region_controller_endpoints()
+
+        endpoint = f"http://{ip['ip']}:5240/MAAS/"
+        if ip["ip"].version == 6:
+            endpoint = f"http://[{ip['ip']}]:5240/MAAS/"
+
+        assert result == [
+            {
+                "subnet": str(subnet["cidr"]),
+                "endpoint": endpoint,
+            }
+        ]
+
     async def test_get_region_controller_endpoints_two_region_controllers(
         self, db: Database, db_connection: AsyncConnection, fixture: Fixture
     ):