lp:~bjornt/maas

Owned by Björn Tillenius
Get this repository:
git clone https://git.launchpad.net/~bjornt/maas
Only Björn Tillenius can upload to this repository. If you are Björn Tillenius please log in for upload directions.

Branches

Name Last Modified Last Commit
maas-anvil-setup 2024-11-21 16:47:52 UTC
Add terraform

Author: Björn Tillenius
Author Date: 2024-09-14 15:09:20 UTC

Add terraform

jenkins-max-processes 2024-08-09 07:59:40 UTC
Use 5 processes.

Author: Björn Tillenius
Author Date: 2024-08-09 07:59:40 UTC

Use 5 processes.

jenkins-test 2024-08-02 09:02:46 UTC
dummy change.

Author: Björn Tillenius
Author Date: 2024-08-02 09:02:46 UTC

dummy change.

bug-2073731-3.4 2024-07-31 07:55:14 UTC
fix: don't fail commissioning if no suitable IPMI ciphers can be detected

Author: Björn Tillenius
Author Date: 2024-07-30 09:46:19 UTC

fix: don't fail commissioning if no suitable IPMI ciphers can be detected

Some BMCs (like HPE ILO 5 3.05) seems to not report all the ciphers
that actually are enabled.

Instead of failing commissioning, we now only print out a warning.

Resolves LP:2073731

(cherry picked from commit b2d55fd8c55b36139547e6b1306a7b96286d7875)
(cherry picked from commit 60fbad31927d726ae9d3098e0aedb7aa9a874f11)

bug-2073731-3.5 2024-07-30 08:56:57 UTC
fix: don't fail commissioning if no suitable IPMI ciphers can be detected

Author: Björn Tillenius
Author Date: 2024-07-29 13:44:09 UTC

fix: don't fail commissioning if no suitable IPMI ciphers can be detected

Some BMCs (like HPE ILO 5 3.05) seems to not report all the ciphers
that actually are enabled.

Instead of failing commissioning, we now only print out a warning.

Resolves LP:2073731

(cherry picked from commit b2d55fd8c55b36139547e6b1306a7b96286d7875)

commission-test-fix-3.4 2024-07-30 08:01:04 UTC
test: Fix test_Commission_starts_commissioning intermittent failure.

Author: Björn Tillenius
Author Date: 2024-07-29 16:32:02 UTC

test: Fix test_Commission_starts_commissioning intermittent failure.

(cherry picked from commit 68802ac8ba80d2ada2fe39b56525b2ed9a4cef8c)
(cherry picked from commit 511ce4f4fa185bf36ddc6c7fea189f4f9beb5b11)

bug-2073731-deal-with-bmc-lies 2024-07-29 09:21:04 UTC
fix: don't fail commissioning if no suitable IPMI ciphers can be detected

Author: Björn Tillenius
Author Date: 2024-07-26 13:21:08 UTC

fix: don't fail commissioning if no suitable IPMI ciphers can be detected

Some BMCs (like HPE ILO 5 3.05) seems to not report all the ciphers
that actually are enabled.

Instead of failing commissioning, we now only print out a warning.

Resolves LP:2073731

commission-test-fix-3.5 2024-07-29 09:17:01 UTC
test: Fix test_Commission_starts_commissioning intermittent failure.

Author: Björn Tillenius
Author Date: 2024-05-27 08:12:24 UTC

test: Fix test_Commission_starts_commissioning intermittent failure.

(cherry picked from commit 68802ac8ba80d2ada2fe39b56525b2ed9a4cef8c)

bug-2073731-hotfix 2024-07-26 12:47:23 UTC
test: fix intermitten test_Commission_starts_commissioning failure

Author: Björn Tillenius
Author Date: 2024-07-26 12:47:23 UTC

test: fix intermitten test_Commission_starts_commissioning failure

The test assumed a certain ordering of the ids, but relied
on postgres default ordering.

perftests-v3-api-query-count 2024-07-25 08:03:16 UTC
test: enable query counting for v3 API performance tests

Author: Björn Tillenius
Author Date: 2024-07-24 08:59:34 UTC

test: enable query counting for v3 API performance tests

Now we collect the number of queries that are being executed during
performance tests for the v3 API.

As a side effect, we now also the API server in-process, making
debugging easier, and should ensure that garbage is collect before
and after each test.

perftests-count-queries 2024-07-23 08:54:49 UTC
test: fix so that utilities/run-perf-tests-ci collect query count

Author: Björn Tillenius
Author Date: 2024-07-23 08:54:49 UTC

test: fix so that utilities/run-perf-tests-ci collect query count

utilities/run-perf-tests-ci used the default --perf-tracers value, which
includes 'queries'. However, it also specified a custom django config,
which set DEBUG to False.

This disabled any query logging, resulting in no query count or timing
being collect.

Now, the 'queries' perftest trace always set DEBUG to True, so that
query count and timing can be collected.

system-tests-fix-3.3 2024-07-12 07:32:54 UTC
fix: during commissioning reset the interface vlan only if an ip address on t...

Author: Jacopo Rota
Author Date: 2024-07-01 17:33:15 UTC

fix: during commissioning reset the interface vlan only if an ip address on that vlan exists

(cherry-picked from f183792675a15179c0d6283d54f97a76e5022031)

(cherry picked from commit 490f440f33c89bad35428abc97c3a3bc0cd0533f)

bug-2029522-3.3 2024-05-29 09:15:30 UTC
fix: lp-2029522. Check if the connection was already dropped in the connectio...

Author: Björn Tillenius
Author Date: 2024-05-29 08:17:35 UTC

fix: lp-2029522. Check if the connection was already dropped in the connectionpool disconnect method.

(cherry picked from commit c97dc1b3d16b561eb72cd282e83a68678a375570)
(cherry picked from commit a9f8269668860676c06ffd28adb07d1d59862f74)

bug-2029522-3.4 2024-05-29 07:41:04 UTC
fix: lp-2029522. Check if the connection was already dropped in the connectio...

Author: Jacopo Rota
Author Date: 2024-04-03 21:56:25 UTC

fix: lp-2029522. Check if the connection was already dropped in the connectionpool disconnect method.

(cherry picked from commit c97dc1b3d16b561eb72cd282e83a68678a375570)

bug-2066276-3.3 2024-05-27 08:21:55 UTC
Bug #2066276: ipv6 test failures: AttributeError: 'RRHeader' object has no at...

Author: Björn Tillenius
Author Date: 2024-05-27 07:35:00 UTC

Bug #2066276: ipv6 test failures: AttributeError: 'RRHeader' object has no attribute '_address'

fix: parse DNS results correctly

(cherry picked from commit 4f6ef7d4e2feab5445b39330949ed5a13d10d526)
(cherry picked from commit 557d3f62aa3399150b84cfc95949cd3416c6ce04)

Limit test processes in parallel to 4 by default.

It's possible to change the number of parallel processes by passing
in the MAAS_MAX_TEST_PROCESSES environment variable. For example:
MAAS_MAX_TEST_PROCESSES=8 utilities/run-py-tests-ci

This aims to reduce the number of intermittent failures in our CI.

(cherry picked from commit b2df4b603143d36e95b7e0d8e6b442fd2ac7c8ed)

Apply intermittent test failure fix from e4d49a5503.

(cherry picked from commit 1c07a56167bebc3292de6d5255374d05ed156e67)

intermittent-test-commissioning-failure 2024-05-27 07:10:30 UTC
Fix test_Commission_starts_commissioning intermittent failure.

Author: Björn Tillenius
Author Date: 2024-05-27 07:10:30 UTC

Fix test_Commission_starts_commissioning intermittent failure.

bug-2066276-3.4 2024-05-27 07:00:46 UTC
Apply intermittent test failure fix from e4d49a5503.

Author: Björn Tillenius
Author Date: 2024-05-27 07:00:46 UTC

Apply intermittent test failure fix from e4d49a5503.

3.4-test-ipv6 2024-05-23 12:51:01 UTC
Limit number of subprocesses.

Author: Björn Tillenius
Author Date: 2024-05-23 12:51:01 UTC

Limit number of subprocesses.

3.4-dhcp-test-failure-debug 2024-05-23 11:17:51 UTC
Limit test processes in parallel to 4 by default.

Author: Björn Tillenius
Author Date: 2024-05-23 07:34:00 UTC

Limit test processes in parallel to 4 by default.

It's possible to change the number of parallel processes by passing
in the MAAS_MAX_TEST_PROCESSES environment variable. For example:

  MAAS_MAX_TEST_PROCESSES=8 utilities/run-py-tests-ci

This aims to reduce the number of intermittent failures in our CI.

limit-parallel-tests-ci 2024-05-23 11:15:37 UTC
Limit test processes in parallel to 4 by default.

Author: Björn Tillenius
Author Date: 2024-05-23 07:34:00 UTC

Limit test processes in parallel to 4 by default.

It's possible to change the number of parallel processes by passing
in the MAAS_MAX_TEST_PROCESSES environment variable. For example:

  MAAS_MAX_TEST_PROCESSES=8 utilities/run-py-tests-ci

This aims to reduce the number of intermittent failures in our CI.

bug-2066276-3.5 2024-05-21 14:24:46 UTC
fix: parse DNS results correctly

Author: Alexsander de Souza
Author Date: 2024-05-09 20:35:21 UTC

fix: parse DNS results correctly

(cherry picked from commit 4f6ef7d4e2feab5445b39330949ed5a13d10d526)

bug-2007297-3.3 2024-05-21 07:31:10 UTC
Create a Session before instantiating the pylxd Client

Author: Adam Collard
Author Date: 2023-02-20 15:43:19 UTC

Create a Session before instantiating the pylxd Client

(cherry picked from commit 33963ee1eb39c745729dd10cf789f6af04d80e94)

bug-2052958-3.3 2024-05-10 13:25:47 UTC
fix: LP:2052958 cope with disks with missing serial metadata

Author: Adam Collard
Author Date: 2024-03-12 10:49:47 UTC

fix: LP:2052958 cope with disks with missing serial metadata

(cherry picked from commit f57ed04744e7110659d7b6833b2ad2b1571a020e)
(cherry picked from commit c13a8beb452f270d795fd1a722928287ed51bb1f)

bug-2031482-revert-3.3 2024-05-10 08:34:43 UTC
Revert "fix: lp-2031482. If a controller interface has moved to a VLAN in ano...

Author: Björn Tillenius
Author Date: 2024-05-10 08:34:43 UTC

Revert "fix: lp-2031482. If a controller interface has moved to a VLAN in another fabric, move all the assigned subnets to the new VLAN/fabric. For machines, simply clear all the IPs."

This reverts commit d65e60a89177569b7d94a3f91152f437b513d70c.

This is temporary until we release 3.3.7. It will be re-applied after 3.3.7 is
released.

revert-bug-2043970-3.3 2024-05-03 10:14:39 UTC
Revert "fix(metadataserver): leave discovered interfaces disconnected"

Author: Björn Tillenius
Author Date: 2024-05-03 10:14:39 UTC

Revert "fix(metadataserver): leave discovered interfaces disconnected"

This reverts commit 41fb68392a2d22da358ed337633c166f70bfbcb0.

exit-rescue-mode-timeout 2024-05-02 07:38:39 UTC
Don't transition to FAILED_EXITING_RESCUE_MODE too early.

Author: Björn Tillenius
Author Date: 2024-05-02 07:14:50 UTC

Don't transition to FAILED_EXITING_RESCUE_MODE too early.

When exiting rescue mode, the node is either turned off or power cycled
in a post commit hook. Then, every 15 seconds, we check whether the
machine is on or off and updates the machine status.

If that check happens while a power cycle is happening, or before
the machine is actually turned off, the machine would go to
FAILED_EXITING_RESCUE_MODE incorrectly.

We now wait some time to elapse since the start of exiting rescue
mode before marking the node as failed.

This is a temporary fix until we write a workflow for this.

bug-2043970-vlan-interfaces-3.4 2024-04-29 12:44:39 UTC
Bug #2043970: MAAS 3.2.9 creates for Calico Interfaces 80.000 fabrics

Author: Björn Tillenius
Author Date: 2024-04-29 09:36:49 UTC

Bug #2043970: MAAS 3.2.9 creates for Calico Interfaces 80.000 fabrics

Redo the fix for bug #2043970.

In some cases we need to create VLANs/fabrics for interfaces that don't have
links. For example for VLAN interfaces, often it's the VLAN interface that has
an address, while the underlying physical interface often is without any
address. In that case, the physical interface should have a VLAN that is on the
same fabric as the VLAN interface.

Also removed the check whether a machine is a controller. A controller is not
special. It's a deployed machine. If Calico is installed on a controller, we
should not create useless fabrics.

(cherry picked from commit 94dac1082c3a3958e7c01f29e1d0320a775633ae)
(cherry picked from commit 3c34344be9f9ab6f283a505193c678ff039c17ef)

bug-2043970-vlan-interfaces-3.5 2024-04-29 08:41:30 UTC
Bug #2043970: MAAS 3.2.9 creates for Calico Interfaces 80.000 fabrics

Author: Björn Tillenius
Author Date: 2024-04-29 08:18:25 UTC

Bug #2043970: MAAS 3.2.9 creates for Calico Interfaces 80.000 fabrics

Redo the fix for bug #2043970.

In some cases we need to create VLANs/fabrics for interfaces that don't have
links. For example for VLAN interfaces, often it's the VLAN interface that has
an address, while the underlying physical interface often is without any
address. In that case, the physical interface should have a VLAN that is on the
same fabric as the VLAN interface.

Also removed the check whether a machine is a controller. A controller is not
special. It's a deployed machine. If Calico is installed on a controller, we
should not create useless fabrics.

(cherry picked from commit 94dac1082c3a3958e7c01f29e1d0320a775633ae)

bug-2043970-vlan-interfaces 2024-04-26 14:19:08 UTC
Bug #2043970: MAAS 3.2.9 creates for Calico Interfaces 80.000 fabrics

Author: Björn Tillenius
Author Date: 2024-04-25 15:42:27 UTC

Bug #2043970: MAAS 3.2.9 creates for Calico Interfaces 80.000 fabrics

Redo the fix for bug #2043970.

In some cases we need to create VLANs/fabrics for interfaces that don't have
links. For example for VLAN interfaces, often it's the VLAN interface that has
an address, while the underlying physical interface often is without any
address. In that case, the physical interface should have a VLAN that is on the
same fabric as the VLAN interface.

Also removed the check whether a machine is a controller. A controller is not
special. It's a deployed machine. If Calico is installed on a controller, we
should not create useless fabrics.

bug-2056740-3.5 2024-03-13 15:51:17 UTC
Bug #2056740: Can't commission/deploy AMT machines

Author: Björn Tillenius
Author Date: 2024-03-13 14:48:45 UTC

Bug #2056740: Can't commission/deploy AMT machines

The maas-power script was passed "--boot-mode pxe" for AMT machines
and failed, since such a parameter wasn't defined.

All other power drivers, including the newer AMT one, sets PXE boot every
time the machine is powered on. I changed things, so that "boot-mode" is
no longer passed, and the older AMT driver also sets the machine to PXE
boot whenever it's turned on.

(cherry picked from commit 116ccedb102a78136d9e1d62d3144850e861947e)

bug-2057750-3.5 2024-03-13 10:38:29 UTC
Bug #2057750: Can't pxe boot legacy non-uefi machines

Author: Björn Tillenius
Author Date: 2024-03-13 09:07:33 UTC

Bug #2057750: Can't pxe boot legacy non-uefi machines

The rewrite rules in maas agent had 'bootloader' instead of
'bootloaders' for non-UEFI bootloaders.

(cherry picked from commit c9c16ac166c1eab8a25ea95a43b9f6138d58ac26)

bug-2056740-amt-boot-mode 2024-03-13 10:32:46 UTC
Bug #2056740: Can't commission/deploy AMT machines

Author: Björn Tillenius
Author Date: 2024-03-13 10:32:46 UTC

Bug #2056740: Can't commission/deploy AMT machines

The maas-power script was passed "--boot-mode pxe" for AMT machines
and failed, since such a parameter wasn't defined.

All other power drivers, including the newer AMT one, sets PXE boot every
time the machine is powered on. I changed things, so that "boot-mode" is
no longer passed, and the older AMT driver also sets the machine to PXE
boot whenever it's turned on.

bug-2057750-non-legacy-bootloaders 2024-03-13 08:08:10 UTC
Bug #2057750: Can't pxe boot legacy non-uefi machines

Author: Björn Tillenius
Author Date: 2024-03-13 08:08:10 UTC

Bug #2057750: Can't pxe boot legacy non-uefi machines

The rewrite rules in maas agent had 'bootloader' instead of
'bootloaders' for non-UEFI bootloaders.

bug-2052958-3.4 2024-03-12 09:23:04 UTC
fix: LP:2052958 cope with disks with missing serial metadata

Author: Adam Collard
Author Date: 2024-02-13 10:16:34 UTC

fix: LP:2052958 cope with disks with missing serial metadata

(cherry picked from commit f57ed04744e7110659d7b6833b2ad2b1571a020e)

region-ip-not-valid 2024-02-20 09:56:58 UTC
failed to detect a valid IP address from 'None'

Author: Björn Tillenius
Author Date: 2024-02-20 08:30:13 UTC

failed to detect a valid IP address from 'None'

In the configure workflow, the query for getting the region IPs
included None values, which broke the workflow.

Changed the query not to include any None values.

bug-2053033-3.3-hotfix 2024-02-14 14:07:16 UTC
Bug #2053033: Creating MAAS Virsh VM does not work (libvirt: error)

Author: Björn Tillenius
Author Date: 2024-02-14 13:54:38 UTC

Bug #2053033: Creating MAAS Virsh VM does not work (libvirt: error)

For some reason virsh prints out an error about executing
pkttyagent. This happens only on some machines, and we don't know why.

But the error seems harmless. This patch ignores the error and
lets the connection succeed.

(cherry picked from commit f0005e39bcadfc366c76e713c444739179743c84)
(cherry picked from commit 9eb3ca242e3c57f1b7ab1a1b6537ee4dfffb2aa6)
(cherry picked from commit 052a895bfac55e414bf5b02e5e28122bff12a532)

bug-2053033-3.3 2024-02-14 13:30:14 UTC
Bug #2053033: Creating MAAS Virsh VM does not work (libvirt: error)

Author: Björn Tillenius
Author Date: 2024-02-14 11:44:33 UTC

Bug #2053033: Creating MAAS Virsh VM does not work (libvirt: error)

For some reason virsh prints out an error about executing
pkttyagent. This happens only on some machines, and we don't know why.

But the error seems harmless. This patch ignores the error and
lets the connection succeed.

(cherry picked from commit f0005e39bcadfc366c76e713c444739179743c84)
(cherry picked from commit 9eb3ca242e3c57f1b7ab1a1b6537ee4dfffb2aa6)

bug-2053033-3.4-hotfix 2024-02-14 13:26:39 UTC
Bug #2053033: Creating MAAS Virsh VM does not work (libvirt: error)

Author: Björn Tillenius
Author Date: 2024-02-14 11:44:33 UTC

Bug #2053033: Creating MAAS Virsh VM does not work (libvirt: error)

For some reason virsh prints out an error about executing
pkttyagent. This happens only on some machines, and we don't know why.

But the error seems harmless. This patch ignores the error and
lets the connection succeed.

(cherry picked from commit f0005e39bcadfc366c76e713c444739179743c84)
(cherry picked from commit 9eb3ca242e3c57f1b7ab1a1b6537ee4dfffb2aa6)

bug-2053033-3.4 2024-02-14 10:43:40 UTC
Bug #2053033: Creating MAAS Virsh VM does not work (libvirt: error)

Author: Björn Tillenius
Author Date: 2024-02-14 10:29:40 UTC

Bug #2053033: Creating MAAS Virsh VM does not work (libvirt: error)

For some reason virsh prints out an error about executing
pkttyagent. This happens only on some machines, and we don't know why.

But the error seems harmless. This patch ignores the error and
lets the connection succeed.

(cherry picked from commit f0005e39bcadfc366c76e713c444739179743c84)

bug-2053033-failed-login-virsh 2024-02-14 09:31:00 UTC
Bug #2053033: Creating MAAS Virsh VM does not work (libvirt: error)

Author: Björn Tillenius
Author Date: 2024-02-14 09:31:00 UTC

Bug #2053033: Creating MAAS Virsh VM does not work (libvirt: error)

For some reason virsh prints out an error about executing
pkttyagent. This happens only on some machines, and we don't know why.

But the error seems harmless. This patch ignores the error and
lets the connection succeed.

maas-agent-http-206 2024-02-01 15:50:01 UTC
Lint.

Author: Björn Tillenius
Author Date: 2024-02-01 15:50:01 UTC

Lint.

temporal-sqlalchemy-spike 2024-01-23 14:15:16 UTC
Add a new asyncio worker that can run workflows.

Author: Björn Tillenius
Author Date: 2023-11-14 16:02:38 UTC

Add a new asyncio worker that can run workflows.

inter-tech-power-driver 2024-01-23 14:13:10 UTC
Initial version inter-tech power driver.

Author: Björn Tillenius
Author Date: 2023-09-01 07:04:15 UTC

Initial version inter-tech power driver.

power-driver-more-logging 2023-11-21 09:53:39 UTC
Add more logging for when power action fails.

Author: Björn Tillenius
Author Date: 2023-11-21 09:52:35 UTC

Add more logging for when power action fails.

We had the issue that a machine wouldn't turn on when told
to do so, but the logs didn't give any clues that this was
the case.

fix-self-reference 2023-11-20 16:32:42 UTC
Don't reference self inside of a @transaction block.

Author: Björn Tillenius
Author Date: 2023-11-20 16:30:40 UTC

Don't reference self inside of a @transaction block.

Inside a @transaction block, a new transaction is being created
and 'self' is a stale reference from an old transaction.

bug-2042540-update-power-stale-object 2023-11-02 10:16:01 UTC
Bug #204254: Machine sometimes revert to old status after power control Edit

Author: Björn Tillenius
Author Date: 2023-11-02 10:16:01 UTC

Bug #204254: Machine sometimes revert to old status after power control Edit

The async methods related to power control uses multiple threads
and transactions, but they all used the same, stale, Node object.

When using deferToDatabase and transational(), you must always
get fresh values from the database.

maas-power-multiple-choice 2023-11-01 10:08:21 UTC
Allow maas-power to work with multiple-choice fields.

Author: Björn Tillenius
Author Date: 2023-11-01 10:08:21 UTC

Allow maas-power to work with multiple-choice fields.

The IPMI driver allows multiple workaround flags to passed, but maas-power
wouldn't allow that.

bug-2041854-bump-vault-migrate-timeout 2023-10-31 08:19:21 UTC
Bug #2041854: Bump timeout for Vault secret migration

Author: Björn Tillenius
Author Date: 2023-10-31 08:19:21 UTC

Bug #2041854: Bump timeout for Vault secret migration

MAAS can be busy and take more than 30 seconds to restart.

Bump timeout to be twice as long.

flag-image-ephemeral-deploy 2023-09-27 10:05:47 UTC
Flag images that can be deployed to memory in the websocket handler.

Author: Björn Tillenius
Author Date: 2023-09-22 09:47:31 UTC

Flag images that can be deployed to memory in the websocket handler.

bootresources.poll() now returns the 'canBeDeployToMemory' flag
for all resources.

deploy-to-memory-non-ubuntu 2023-09-27 09:32:19 UTC
Allow non-Ubuntu OSes to be deployed to memory.

Author: Björn Tillenius
Author Date: 2023-09-22 08:48:13 UTC

Allow non-Ubuntu OSes to be deployed to memory.

For uploaded files, deploying to memory is supported
if it's tgz or txz image. That's what the initramfs
supports.

can-deploy-to-memory-list-usable-osystems 2023-09-27 09:00:32 UTC
Use f-strings.

Author: Björn Tillenius
Author Date: 2023-09-27 09:00:32 UTC

Use f-strings.

list-all-usable-releases-cleanup 2023-09-25 08:49:50 UTC
Add missing type annotation.

Author: Björn Tillenius
Author Date: 2023-09-25 08:49:50 UTC

Add missing type annotation.

intermittent-filename-test 2023-09-22 06:49:27 UTC
Fix intermittent test_POST_creates_boot_resource failure.

Author: Björn Tillenius
Author Date: 2023-09-22 06:49:27 UTC

Fix intermittent test_POST_creates_boot_resource failure.

tarball-image-filenames 2023-09-14 07:10:25 UTC
Typo.

Author: Björn Tillenius
Author Date: 2023-09-14 07:10:25 UTC

Typo.

custom-image-diskless-spike 2023-09-13 12:39:01 UTC
WIP make tarball ephemeral deploys work.

Author: Björn Tillenius
Author Date: 2023-09-12 07:05:08 UTC

WIP make tarball ephemeral deploys work.

ephemeral-deploy-cloud-init-networking 2023-09-05 06:37:01 UTC
WIP

Author: Björn Tillenius
Author Date: 2023-09-04 13:47:17 UTC

WIP

sqlalchemy-search-spike 2023-07-20 13:44:13 UTC
WIP - zone handler.

Author: Björn Tillenius
Author Date: 2023-07-20 10:13:40 UTC

WIP - zone handler.

fastapi-db-session-tests 2023-07-14 07:57:01 UTC
Add tests for the db_conn FastAPI dependency.

Author: Björn Tillenius
Author Date: 2023-07-10 09:45:06 UTC

Add tests for the db_conn FastAPI dependency.

sqlalchemy-tests-prevent-commit 2023-07-11 12:58:05 UTC
Close db connections for each test.

Author: Björn Tillenius
Author Date: 2023-07-11 12:58:05 UTC

Close db connections for each test.

sqlalchemy-django-db-setup-2 2023-07-07 07:33:51 UTC
Rework maasapiserver tests not to use pytest-postgresql.

Author: Björn Tillenius
Author Date: 2023-07-05 15:17:53 UTC

Rework maasapiserver tests not to use pytest-postgresql.

pytest-extract-db-setup 2023-07-06 13:48:57 UTC
Extract the non-Django database setup into its own pytest plugin.

Author: Björn Tillenius
Author Date: 2023-07-05 10:41:05 UTC

Extract the non-Django database setup into its own pytest plugin.

The new database plugin still uses Django to setup the database,
but it doesn't import Django directly.

This allows the same fixtures to be used for sqlalchemy-based tests.

sqlalchemy-django-db-setup 2023-07-06 13:25:59 UTC
Rework maasapiserver tests not to use pytest-postgresql.

Author: Björn Tillenius
Author Date: 2023-07-05 15:17:53 UTC

Rework maasapiserver tests not to use pytest-postgresql.

sqlalchemy-in-django 2023-07-05 09:25:04 UTC
Fix URL.

Author: Björn Tillenius
Author Date: 2023-07-05 09:25:04 UTC

Fix URL.

current-script-set-foreign-key-constraints 2023-04-27 09:54:40 UTC
Add foreign key constraints for current_foo_script_set attributes.

Author: Björn Tillenius
Author Date: 2022-11-21 14:37:14 UTC

Add foreign key constraints for current_foo_script_set attributes.

move-metadataserver-script-models 2023-04-27 07:15:35 UTC
Move Script metadataserver models to maasserver.

Author: Björn Tillenius
Author Date: 2022-11-18 13:15:39 UTC

Move Script metadataserver models to maasserver.

move-metadataserver-models 2023-04-26 07:37:01 UTC
Add foreign key constraints for current_foo_script_set attributes.

Author: Björn Tillenius
Author Date: 2022-11-21 14:37:14 UTC

Add foreign key constraints for current_foo_script_set attributes.

move-metadataserver-node-models 2023-04-26 07:37:01 UTC
Move Node metadataserver models to maasserver.

Author: Björn Tillenius
Author Date: 2022-11-17 16:12:14 UTC

Move Node metadataserver models to maasserver.

bug-2009805-3.3 2023-03-13 12:35:23 UTC
Bug #2009805: machine deploy install_kvm=True fails

Author: Alberto Donato
Author Date: 2023-02-03 09:39:12 UTC

Bug #2009805: machine deploy install_kvm=True fails

exclude discovered IPs when selecting which to use for VM hosts deploys

(cherry picked from commit 91442ef7aecbcd2caf345b8abad579876f5d9448)

bug-2009805-wrong-kvm-ip 2023-03-13 12:24:06 UTC
LP #2009805: machine deploy install_kvm=True fails

Author: Björn Tillenius
Author Date: 2023-03-13 12:24:06 UTC

LP #2009805: machine deploy install_kvm=True fails

Only consider IPs that have been configured by MAAS when choosing the right IP
for the KVM endpoint.

Previously it considered any IP associated with the interface, including
DISCOVERED ones that where used while commissioning the machine.

I couldn't find a reliable way of testing this. There is already a test
for this, and most likely if failed intermittently.

bug-2003310-3.3 2023-03-13 11:13:53 UTC
Bug #2003310: Refresh scripts are not re-run if they pass, but fail to report...

Author: Björn Tillenius
Author Date: 2023-03-13 11:11:32 UTC

Bug #2003310: Refresh scripts are not re-run if they pass, but fail to report the results to the region

While refreshing the hardware information for controllers,
the scripts might all pass, but when reporting the results
back to the metadata server, something went wrong.

The exception was swallowed and ignored, though, so the
networking service didn't noticed it and assumed that
all scripts had passed.

This changes things so that the signal exception is caught
in the networking service itself, so it's aware that something
went wrong.

(cherry picked from commit 42cdcb554f65574d216aaff06ad592675920922a)

bug-2003310-signal-error 2023-03-10 14:25:33 UTC
Improve log message.

Author: Björn Tillenius
Author Date: 2023-03-10 14:25:33 UTC

Improve log message.

bug-2003310-debug 2023-03-09 14:03:28 UTC
Add some debug logging to debug bug #2003310.

Author: Björn Tillenius
Author Date: 2023-03-09 13:55:17 UTC

Add some debug logging to debug bug #2003310.

machine-list-spike-ip-address-model 2023-01-27 14:35:34 UTC
Make sqlalchemy handlers use new ip model.

Author: Björn Tillenius
Author Date: 2023-01-27 09:04:45 UTC

Make sqlalchemy handlers use new ip model.

sqlalchemy-boot-interface 2023-01-25 10:06:43 UTC
Allow boot_interface_id to be None in the sqlalchemy handlers.

Author: Björn Tillenius
Author Date: 2023-01-25 10:06:43 UTC

Allow boot_interface_id to be None in the sqlalchemy handlers.

sampledata-vid-error 2023-01-24 15:00:35 UTC
Fix sample data generation to generate valid vids.

Author: Björn Tillenius
Author Date: 2023-01-24 14:59:00 UTC

Fix sample data generation to generate valid vids.

MAAS ensures that the vid for VLANs are less than 4095.

bug-1990172-3.3 2023-01-23 11:23:22 UTC
LP #1990172: "20-maas-03-machine-resources" commissioning script improperly r...

Author: Björn Tillenius
Author Date: 2023-01-20 17:18:56 UTC

LP #1990172: "20-maas-03-machine-resources" commissioning script improperly reports a Pass when the test fails

The results was piped to 'tee', but pipefail wasn't set.

(cherry picked from commit 15f64a96a59ef39cde0bbb06b79948e05e03c147)

bug-1990172-no-pipefail 2023-01-20 16:37:13 UTC
LP #1990172: "20-maas-03-machine-resources" commissioning script improperly r...

Author: Björn Tillenius
Author Date: 2023-01-20 16:37:13 UTC

LP #1990172: "20-maas-03-machine-resources" commissioning script improperly reports a Pass when the test fails

The results was piped to 'tee', but pipefail wasn't set.

perf-test-always-run 2023-01-20 11:36:03 UTC
Run the performance tests together with the normal pytest tests.

Author: Björn Tillenius
Author Date: 2023-01-20 11:36:03 UTC

Run the performance tests together with the normal pytest tests.

They are quick to run with an empty database, and by running them
CI will ensure that they don't break.

Also change run-perf-tests-ci to not hide the output, to make
it easier to debug failures.

list-spike-sqlalchemy-fewer-subqueries 2023-01-18 12:45:31 UTC
Add an sqlalchemy handler that performs multiple queries.

Author: Björn Tillenius
Author Date: 2023-01-17 14:32:40 UTC

Add an sqlalchemy handler that performs multiple queries.

The purpose of that is to see if we can optimize each query
individually to make it perform better.

Also change the way status_message is calculated, from a CTE
to a scalar subquery. This makes the query significantly faster.

listing-spike-sqlalchemy-core 2023-01-13 10:13:50 UTC
Add sqlalchemy core handler that gets all data in one query.

Author: Björn Tillenius
Author Date: 2022-12-07 09:23:39 UTC

Add sqlalchemy core handler that gets all data in one query.

Currently it's not optimized at all. It returns the right data, but probably
needs to be rewritten in order to be faster.

There's also a handler using sqlalchemy ORM, but it's incomplete and disabled
for now.

pytest-no-pythonseeds 2023-01-09 13:28:58 UTC
Make seeds reporting work when no setup has been done.

Author: Björn Tillenius
Author Date: 2023-01-03 15:18:55 UTC

Make seeds reporting work when no setup has been done.

perftests-no-gc-collect-noise 2023-01-05 10:12:45 UTC
Control the garbage collection for the performance tests.

Author: Björn Tillenius
Author Date: 2023-01-05 10:12:45 UTC

Control the garbage collection for the performance tests.

Before, one test could create a lot of garbage that then got
collected while running another test. That made the second test
look slower than it actually was.

Now we collect the garbage before a test being run, and also
collect it after the test is being run, including the last collection
in the timing of the test.

baseline-test 2022-12-02 08:17:19 UTC
Compare ids instead of the length.

Author: Björn Tillenius
Author Date: 2022-12-02 08:17:19 UTC

Compare ids instead of the length.

test_handles_missing_system_handler_on_notification-debug 2022-11-28 16:50:41 UTC
Add debug logging to test_handles_missing_system_handler_on_notification.

Author: Björn Tillenius
Author Date: 2022-11-28 16:50:41 UTC

Add debug logging to test_handles_missing_system_handler_on_notification.

It sometimes fails intermittently. I have a theory on why, but I want to see
some debug logs from a failure to confirm my finding, since I can't reproduce
it locally.

pytest-django-setup 2022-11-28 14:33:43 UTC
Add a pytest DB fixture to set up the database for the tests.

Author: Björn Tillenius
Author Date: 2022-11-24 14:48:55 UTC

Add a pytest DB fixture to set up the database for the tests.

You now no longer have to run the pytest tests that require a DB using
bin/database. Instead you run bin/pytest and it will set up the DB
automatically. It still uses the bin/database infrastructure under the hood,
and it will re-use the DB by default. So the time it takes to run the tests is
the same as before.

For the performance tests, it's possible to pass in a DB dump to use as well.

I removed pytest-django, since we want to control how the DB is
created and cleaned up.

pytest-seeds-cleanup 2022-11-28 14:26:15 UTC
Print out the seeds for pytest test only if they fail.

Author: Björn Tillenius
Author Date: 2022-11-28 14:26:15 UTC

Print out the seeds for pytest test only if they fail.

perf-test-cli-options 2022-11-25 10:07:58 UTC
Fix tests.

Author: Björn Tillenius
Author Date: 2022-11-25 10:07:58 UTC

Fix tests.

perf-test-no-custom-runner 2022-11-24 15:19:22 UTC
Drop default scope

Author: Björn Tillenius
Author Date: 2022-11-24 15:19:22 UTC

Drop default scope

perf-test-no-custom-decorator 2022-11-24 13:47:55 UTC
Remove the @perf_test decorator.

Author: Björn Tillenius
Author Date: 2022-11-23 10:52:32 UTC

Remove the @perf_test decorator.

It's not needed, and it was somewhat broken. It reverted back to
a savepoint, unless commit_transaction was true. In that case
it simply removed the savepoint. I'm not quite sure what the intent
was there. If it was to simulate a commit, it was in the wrong
place, since it was outside the block that measures the duration.

The transaction is rolled back elsewhere for each tests, so no
need for a custom decorator. The decorator also had logic for
skipping the tests if django wasn't loaded, but I don't see
a use case for that.

perf-test-dont-measure-setup 2022-11-23 09:55:08 UTC
Make it move explicit what the measure in the performance tests

Author: Björn Tillenius
Author Date: 2022-11-23 08:17:27 UTC

Make it move explicit what the measure in the performance tests

Before, we measured how long the whole test took to run. That includes
any local setup you do in the test, but also the setup of any fixtures
the test uses.

perftest-websocket-machine-list-all 2022-11-22 14:41:50 UTC
Add a performance tests for listing all machines with the websocket.

Author: Björn Tillenius
Author Date: 2022-11-22 14:41:50 UTC

Add a performance tests for listing all machines with the websocket.

With this it's easier to track what the default page size should be.

perftest-no-implicit-path 2022-11-22 14:28:31 UTC
No implicit, hardcoded, path for bin/test.perf

Author: Björn Tillenius
Author Date: 2022-11-22 14:28:31 UTC

No implicit, hardcoded, path for bin/test.perf

bin/test.perf always passed src/maasperf to pyttest. This made it
impossible to run only a single test.

CI uses utilities/run-perf-tests-ci, which already explicitly passes
src/maasperf as the path.

move-authorization-backend 2022-11-21 10:24:11 UTC
Lint.

Author: Björn Tillenius
Author Date: 2022-11-21 10:24:11 UTC

Lint.

schemaspy-jammy 2022-11-16 08:42:28 UTC
Fix schemaspy after switch to jammy.

Author: Björn Tillenius
Author Date: 2022-10-11 09:26:00 UTC

Fix schemaspy after switch to jammy.

bug-1992330-3.2 2022-11-16 08:13:45 UTC
Don't return ipv6 boot addresses for ipv4 subnets.

Author: Björn Tillenius
Author Date: 2022-10-28 13:05:36 UTC

Don't return ipv6 boot addresses for ipv4 subnets.

An ipv4 subnet won't be able to use ipv6 addresses, and it would break the
DHCP config.

(cherry picked from commit 425a78cfd666e05757bf6f72e63c48bdf0f807df)

bug-1990383-link-subnet-new 2022-11-15 09:13:12 UTC
LP #1990383: Link subnet on new machine

Author: Björn Tillenius
Author Date: 2022-11-15 09:13:12 UTC

LP #1990383: Link subnet on new machine

Fixed the API so that it allows editing interfaces the same way the UI allows.

bug-1988229-dhcp-snippet-relay 2022-11-15 08:26:31 UTC
Rename parameter.

Author: Björn Tillenius
Author Date: 2022-11-15 08:26:31 UTC

Rename parameter.

bug-1996074-diskless-machine-ephemeral 2022-11-11 13:50:50 UTC
LP #1996074: Machine details stuck at "Loading" for machines with no disks

Author: Björn Tillenius
Author Date: 2022-11-11 13:50:50 UTC

LP #1996074: Machine details stuck at "Loading" for machines with no disks

The issue was that if you delete all disks from a machine, the testing
node's current scriptset will be empty. Then when the machine was deploy, the
creation of the installation scriptset would clean up the empty testing
scripset, leaving a reference to a deleted row.

I've changed things so that when you create a new scriptset, we only clean up
scriptsets of the same type. I also fixed the tests, since they didn't actually
create any empty sets. The reason the tests passed before was that they set the
max limit to 1.

Now the real issue is that Node.current_testing_script_set doesn't have a
foreign key in the database, and that the 'on_delete=SET_NULL' doesn't work.
But considering that might be hard to fix, I think it's worth landing this
workaround for now.

admin_can_change_power_type-intermittent 2022-11-10 13:42:14 UTC
Fix test_PUT_admin_can_change_power_type intermittent failure.

Author: Björn Tillenius
Author Date: 2022-11-10 13:42:14 UTC

Fix test_PUT_admin_can_change_power_type intermittent failure.

If the power type is 'lxd', it fails, since it can't generate the certificate.

bug-1955709-may-reboot 2022-11-09 17:20:16 UTC
Fix lint.

Author: Björn Tillenius
Author Date: 2022-11-09 17:20:16 UTC

Fix lint.

1100 of 426 results
This repository contains Public information 
Everyone can see this information.

Subscribers