Merge ~bjornt/maas:admin_can_change_power_type-intermittent into maas:master

Proposed by Björn Tillenius
Status: Merged
Approved by: Björn Tillenius
Approved revision: e6caed0ec13ea2af59ee900c2fa2b24c2fbcfbec
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~bjornt/maas:admin_can_change_power_type-intermittent
Merge into: maas:master
Diff against target: 26 lines (+4/-4)
1 file modified
src/maasserver/api/tests/test_machine.py (+4/-4)
Reviewer Review Type Date Requested Status
Alberto Donato (community) Approve
MAAS Lander Approve
Review via email: mp+432821@code.launchpad.net

Commit message

Fix test_PUT_admin_can_change_power_type intermittent failure.

If the power type is 'lxd', it fails, since it can't generate the certificate.

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b admin_can_change_power_type-intermittent lp:~bjornt/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: e6caed0ec13ea2af59ee900c2fa2b24c2fbcfbec

review: Approve
Revision history for this message
Alberto Donato (ack) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/api/tests/test_machine.py b/src/maasserver/api/tests/test_machine.py
2index 3e5de4b..c67d4a1 100644
3--- a/src/maasserver/api/tests/test_machine.py
4+++ b/src/maasserver/api/tests/test_machine.py
5@@ -2087,8 +2087,8 @@ class TestMachineAPI(APITestCase.ForUser):
6
7 def test_PUT_admin_can_change_power_type(self):
8 self.become_admin()
9- original_power_type = factory.pick_power_type()
10- new_power_type = factory.pick_power_type(but_not=[original_power_type])
11+ original_power_type = "ipmi"
12+ new_power_type = "openbmc"
13 machine = factory.make_Node(
14 owner=self.user,
15 power_type=original_power_type,
16@@ -2107,8 +2107,8 @@ class TestMachineAPI(APITestCase.ForUser):
17 self.assertEqual(new_power_type, reload_object(machine).power_type)
18
19 def test_PUT_non_admin_cannot_change_power_type(self):
20- original_power_type = factory.pick_power_type()
21- new_power_type = factory.pick_power_type(but_not=[original_power_type])
22+ original_power_type = "ipmi"
23+ new_power_type = "openbmc"
24 machine = factory.make_Node(
25 owner=self.user, power_type=original_power_type
26 )

Subscribers

People subscribed via source and target branches