Merge ~bjornt/maas:bug-1845459-2.6 into maas:2.6
Proposed by
Björn Tillenius
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Björn Tillenius | ||||
Approved revision: | a512bc1b0c461d121457864568406f9082aa36b8 | ||||
Merge reported by: | MAAS Lander | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~bjornt/maas:bug-1845459-2.6 | ||||
Merge into: | maas:2.6 | ||||
Diff against target: |
60 lines (+27/-0) 2 files modified
src/metadataserver/api_twisted.py (+10/-0) src/metadataserver/tests/test_api_twisted.py (+17/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
MAAS Lander | Approve | ||
Björn Tillenius | Approve | ||
Review via email: mp+373416@code.launchpad.net |
Commit message
LP #1845459: Failure creating KVM pod in CI
Re-raise DatabaseErrors if form_pod.save() raises an exception.
The old code tried to mark the node as failed deployment, which failed
since the transaction was broken. Further more, the transaction wouldn't
be retried, which would have make the deploy succeed.
This is a stop-gap fix that improves the situation slightly. It's made
small so tha it can be backported to 2.6. The real fix is to refactor
the processing of the messages, so that marking the node as failed or
succeeded happens in a separate transaction.
(cherry picked from commit 6df0418010f4926
To post a comment you must log in.
Self-approve backport