Code review comment for ~bitfehler/cloud-init:bitfehler/load_seed

Revision history for this message
Conrad Hoffmann (bitfehler) wrote :

Thank you for the comments. I indeed somewhat misjudged the relation of the nocloud and nocloud-net data sources.

To clarify, my main objective was a) as mentioned by Scott and also the hope to maybe unify some of the approaches to reading the seed (like getting rid of read_optional_seed and potentially also pathprefix2dict in a follow-up).

However, I also think b) would be valuable. I am happy to look at adding ephemeral DHCP, but maybe in a different MR?

I now understand that this certainly doesn't fix https://bugs.launchpad.net/cloud-init/+bug/1809277. I am unsure about https://bugs.launchpad.net/cloud-init/+bug/1809180, but I read it like if the nocloud-net does render the "new" network config even though the network is already up then that's fine. I will try to get clarification from the submitter.

Would you be ok with merging this if I update the description and commit messages to reflect the narrower scope?

« Back to merge proposal