Code review comment for ~bitfehler/cloud-init:bitfehler/load_seed

Revision history for this message
Scott Moser (smoser) wrote :

I'm not sure that I understand the intent here.

The subject line says:
 Support network-config in nocloud(-net) data source

But nocloud-net cannot ever really provide network-data.
It simply runs too late. No "network" datasources can apply network config as before they have the opportunity to read information the network is already up.

At this point in cluod-init none of the renderers are idempotent. They have to be written before networking is brought up by the OS.

So what we *can* accomplish now (and maybe what this does?) is:

a.) datasourceNoCloud could read networking files from a 'seedfrom'. It already can read network-config from /var/lib/cloud/nocloud/network-config

b.) dataSourceNoCloud could use ephemeral networking to attempt 'seedfrom' of http/https.

But what we can't (I don't think) do:

c.) dataSourceNoCloud-net support reading network-config *at all*.

Last thing... In your commit message, if you believe that you fix those bugs,
please use:
 LP: #XXXXX
 LP: #YYYYY

then all the tools and such will read that and handle closing/fixing bugs.

review: Needs Information

« Back to merge proposal