> What would that mean for this PR? Should I leave it as is? Or should I
> change it so that only the nocloud data source uses the new function?
> I don't mind this waiting for the next release, I do understand it is
> a slight change in behavior.
In case you missed, I had some comments you can see below in the diff output
about the unittests. Let's address those first.
As for this branch; it appears to me to be a super-set of capabilities
more than a change in existing behavior. That is, I expect the datasource
given the same inputs to produce the same behavior;
We are likely to take the updated behavior into master, and include that in
the Ubuntu E release; it could be disabled by default on previous releases
but allowing users to opt-in to the new behavior.
> What would that mean for this PR? Should I leave it as is? Or should I
> change it so that only the nocloud data source uses the new function?
> I don't mind this waiting for the next release, I do understand it is
> a slight change in behavior.
In case you missed, I had some comments you can see below in the diff output
about the unittests. Let's address those first.
As for this branch; it appears to me to be a super-set of capabilities
more than a change in existing behavior. That is, I expect the datasource
given the same inputs to produce the same behavior;
We are likely to take the updated behavior into master, and include that in
the Ubuntu E release; it could be disabled by default on previous releases
but allowing users to opt-in to the new behavior.