Code review comment for lp:~binli/unity-control-center/1291862

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for the work, the change seems fine to me and it looks like it should apply to upstream GNOME (the code seems similar in https://git.gnome.org/browse/gnome-control-center/plain/panels/sound/gvc-mixer-dialog.c)

Could you forward the change to them (https://bugzilla.gnome.org/enter_bug.cgi?product=gnome-control-center)

It also looks like you could apply the same fix for the output as well (not sure how frequent it is to get a machine without audio ouput but it looks like it would lead to the same issue)

review: Needs Fixing

« Back to merge proposal