Merge lp:~binli/unity-control-center/1291862 into lp:unity-control-center
Proposed by
Bin Li
Status: | Merged |
---|---|
Approved by: | Iain Lane |
Approved revision: | 12757 |
Merged at revision: | 12760 |
Proposed branch: | lp:~binli/unity-control-center/1291862 |
Merge into: | lp:unity-control-center |
Diff against target: |
83 lines (+28/-2) 2 files modified
debian/changelog (+6/-0) panels/sound/gvc-mixer-dialog.c (+22/-2) |
To merge this branch: | bzr merge lp:~binli/unity-control-center/1291862 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Iain Lane | Approve | ||
Bin Li (community) | Needs Resubmitting | ||
Sebastien Bacher | Needs Fixing | ||
David Henningsson | Pending | ||
PS Jenkins bot | Pending | ||
Review via email: mp+211258@code.launchpad.net |
Description of the change
Disable the input bar when there are no input devices.
To post a comment you must log in.
Thank you for the work, the change seems fine to me and it looks like it should apply to upstream GNOME (the code seems similar in https:/ /git.gnome. org/browse/ gnome-control- center/ plain/panels/ sound/gvc- mixer-dialog. c)
Could you forward the change to them (https:/ /bugzilla. gnome.org/ enter_bug. cgi?product= gnome-control- center)
It also looks like you could apply the same fix for the output as well (not sure how frequent it is to get a machine without audio ouput but it looks like it would lead to the same issue)