Code review comment for lp:~bialix/bzr/deprecate

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/25/2010 5:26 AM, Alexander Belchenko wrote:
> Alexander Belchenko has proposed merging lp:~bialix/bzr/deprecate into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
>
> this patch fixes todo in FtpTransport.get() about decode parameter. That parameter is not used actually. While fixing this I found that GioTransport has the same parameter (I smell copy-paste ;-). So I've deprecated decode there as well.

I really don't know what 'decode' was meant to be doing, as at present
there are no calls *to* get that pass decode.

We should check that it isn't used by bzr-upload or something like that.
Otherwise, looks good to me.

 merge: approve

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkx1HuIACgkQJdeBCYSNAANFpQCgyPeWt9BuEXVIGTGy4ken6fzD
JngAoIvoHHCse4WFMTqe7OBH4yJJ2Srf
=Yr01
-----END PGP SIGNATURE-----