Merge lp:~bialix/bzr/deprecate into lp:bzr
Proposed by
Alexander Belchenko
Status: | Merged |
---|---|
Approved by: | John A Meinel |
Approved revision: | no longer in the source branch. |
Merged at revision: | 5392 |
Proposed branch: | lp:~bialix/bzr/deprecate |
Merge into: | lp:bzr |
Diff against target: |
88 lines (+25/-3) 3 files modified
NEWS (+3/-0) bzrlib/transport/ftp/__init__.py (+11/-2) bzrlib/transport/gio_transport.py (+11/-1) |
To merge this branch: | bzr merge lp:~bialix/bzr/deprecate |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John A Meinel | Approve | ||
Review via email: mp+33624@code.launchpad.net |
Commit message
`decode` parameter to get() method in FtpTransport and GioTransport classes is deprecated.
Description of the change
this patch fixes todo in FtpTransport.get() about decode parameter. That parameter is not used actually. While fixing this I found that GioTransport has the same parameter (I smell copy-paste ;-). So I've deprecated decode there as well.
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 8/25/2010 5:26 AM, Alexander Belchenko wrote:
> Alexander Belchenko has proposed merging lp:~bialix/bzr/deprecate into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
>
> this patch fixes todo in FtpTransport.get() about decode parameter. That parameter is not used actually. While fixing this I found that GioTransport has the same parameter (I smell copy-paste ;-). So I've deprecated decode there as well.
I really don't know what 'decode' was meant to be doing, as at present
there are no calls *to* get that pass decode.
We should check that it isn't used by bzr-upload or something like that.
Otherwise, looks good to me.
merge: approve
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
1HuIACgkQJdeBCY SNAANFpQCgyPeWt 9BuEXVIGTGy4ken 6fzD FMTqe7OBH4yJJ2S rf
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAkx
JngAoIvoHHCse4W
=Yr01
-----END PGP SIGNATURE-----