Code review comment for lp:~bialix/bzr/2.4-bug-967060

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/28/2012 4:11 PM, Alexander Belchenko wrote:
> Alexander Belchenko has proposed merging
> lp:~bialix/bzr/2.4-bug-967060 into lp:bzr/2.4.
>
> Requested reviews: bzr-core (bzr-core) Related bugs: Bug #967060 in
> Bazaar: "[win32] `bzr add file` in git tree fails with traceback:
> _Win32Stat misses st_uid/st_gid members"
> https://bugs.launchpad.net/bzr/+bug/967060
>
> For more details, see:
> https://code.launchpad.net/~bialix/bzr/2.4-bug-967060/+merge/99737
>
> _Win32Stat object provides members st_uid and st_gid, those are
> present in Python's os.stat object. These members required for
> external tools like bzr-git and dulwich. (Bug #967060).
>
> I've based the fix on 2.4 branch to make sure we can merge it
> easily from 2.4 up to trunk (2.6). Actually we need this fix in bzr
> 2.5. I don't think there are plans to provide new windows
> installers for next bzr 2.4 releases.
>

I can confirm that 'os.stat()' on Python returns 0 for uid and gid on
regular files. So it seems great to me.

John
=:->

 review: approve

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9zHg0ACgkQJdeBCYSNAAMw4QCfdRgnIS+ME0cCaHnA1z0h8GtU
v7QAnjY23NRh4MzObef1qfbeo4DNclF6
=txr6
-----END PGP SIGNATURE-----