[win32] `bzr add file` in git tree fails with traceback: _Win32Stat misses st_uid/st_gid members

BTW, implicit add via `bzr mkdir foo` works:

C:\Temp\3>bzr init --git
Created a standalone tree (format: git)

C:\Temp\3>bzr mkdir foo
added foo

I guess we'll either have to change bzrlib._walkdirs_win32._Win32Stat to have a st_uid member, or provide a custom index_entry_from_stat function.

Some help with writing such a function from somebody on Windows would be great, as I don't have a way to test here.

IPYthon session:

In [1]: import os

In [4]: st = os.stat('.bzr.log')

In [5]: st
Out[5]: (33206, 0L, 0, 0, 0, 0, 4774L, 1320685506, 1320685506, 1320685405)

In [6]: len(st)
Out[6]: 10

In [7]: import stat

In [8]: st[stat.ST_UID]
Out[8]: 0

In [9]: st[stat.ST_GID]
Out[9]: 0

I'm not sure why you need st_uid, but AFAIK these values are always 0 on Windows.

In [10]: st.
st.__add__ st.__le__ st.n_sequence_fields
st.__class__ st.__len__ st.n_unnamed_fields
st.__contains__ st.__lt__ st.st_atime
st.__delattr__ st.__mul__ st.st_ctime
st.__doc__ st.__ne__ st.st_dev
st.__eq__ st.__new__ st.st_gid
st.__ge__ st.__reduce__ st.st_ino
st.__getattribute__ st.__reduce_ex__ st.st_mode
st.__getitem__ st.__repr__ st.st_mtime
st.__getslice__ st.__rmul__ st.st_nlink
st.__gt__ st.__setattr__ st.st_size
st.__hash__ st.__str__ st.st_uid
st.__init__ st.n_fields

In [10]: st.st_uid
Out[10]: 0

In [11]: st.st_gid
Out[11]: 0

It seems bzrlib._walkdirs_win32._Win32Stat does not follow the interface of Python stat object. I wonder why.

From bzrlib._walkdirs_win32:

cdef class _Win32Stat:
    """Represent a 'stat' result generated from WIN32_FIND_DATA"""

    cdef readonly int st_mode
    cdef readonly double st_ctime
    cdef readonly double st_mtime
    cdef readonly double st_atime
    # We can't just declare this as 'readonly' because python2.4 doesn't define
    # T_LONGLONG as a structure member. So instead we just use a property that
    # will convert it correctly anyway.
    cdef __int64 _st_size

    property st_size:
        def __get__(self):
            return self._st_size

    # os.stat always returns 0, so we hard code it here
    cdef readonly int st_dev
    cdef readonly int st_ino

    def __repr__(self):
        """Repr is the same as a Stat object.

        (mode, ino, dev, nlink, uid, gid, size, atime, mtime, ctime)
        """
        return repr((self.st_mode, 0, 0, 0, 0, 0, self.st_size, self.st_atime,
                     self.st_mtime, self.st_ctime))

It seems that implementation just misses declaration of

cdef readonly int st_uid
cdef readonly int st_gid

So, I think we should fix _Win32Stat class in bzrlib.

Patch was merged into 2.4 branch, but not into 2.5 or trunk. Marked as "In progess" as suggested by vila.