Code review comment for lp:~berdario/quickly/editor-fix

Revision history for this message
Tony Byrne (tony-badwolf) wrote :

Hi Dario
 That was unfortunate. I had a look because writing tests *should* be easy, because it isn't quickly has failed you :(

quickly will use QUICKLY_EDITOR in preference to EDITOR if it is in the environment

so this works in edit.sh for me

QUICKLY_EDITOR="ls -1" quickly edit | grep "__init__"
# ./test_project/__init__.py

piping through grep means I don't have to list every file.

When you call quickly you will always get /usr/bin/quickly unless you change your path

So I use something like this in a makefile when I'm working on a branch
export PATH=path/to/my/quickly/bin:$$PATH

As for the final newline and blank line, it looks to me like a requirement of sed and I think it is just insane. I wrote some patches and tested them with python unittest, the quickly team added python tests capability to the test system to suit me.

« Back to merge proposal