Merge lp:~berdario/quickly/editor-fix into lp:quickly
Proposed by
Dario Bertini
Status: | Needs review |
---|---|
Proposed branch: | lp:~berdario/quickly/editor-fix |
Merge into: | lp:quickly |
Diff against target: |
49 lines (+29/-4) 2 files modified
data/templates/ubuntu-application/edit.py (+4/-4) data/templates/ubuntu-application/test/edit.sh (+25/-0) |
To merge this branch: | bzr merge lp:~berdario/quickly/editor-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Quickly Developers | Pending | ||
Review via email: mp+111751@code.launchpad.net |
Description of the change
if $EDITOR contains a space (e.g. "emacs -nw") calling "quickly edit" would fail
To post a comment you must log in.
Unmerged revisions
- 676. By Dario Bertini
-
The test will ignore stderr, so I can't rely on that to make it detect problems
as a workaround, I hardcoded the output of using "ls -1" as the editor, unfortunately it seems it still doesn't work - 675. By Dario Bertini
-
Added test for "quickly edit"
"env cat" is used as a dummy editor: it has a space to catch the previous bug, and will actually access the files, thus raising an error if quickly will try to open non-existing files - 674. By Dario Bertini
-
Fixed bug: when $EDITOR contains spaces subprocess fails
Hey Dario, thanks for this patch and help to make Quickly better.
You code looks overall good :) However, you can see that we have some automated tests with Quickly, would you mind writing some for this case? (use a dummy EDITOR = cat and cat -option variable)