Code review comment for lp:~berdario/quickly/editor-fix

Revision history for this message
Dario Bertini (berdario) wrote :

I spent one hour trying to write a test that will correctly work when "quickly edit" works, and fail when it fails...

I gave up: see the commit message for r676

among the problems I found when writing the test:

-it won't use the local branch's copy of quickly
-it will fail if the script doesn't have a final newline
-sometimes it saves the output in a result.log, sometimes it doesn't
-it will fail if there's a blank line at the end of the script

« Back to merge proposal