Code review comment for lp:~bbaqar/charms/trusty/plumgrid-edge/charmstore

Revision history for this message
Charles Butler (lazypower) wrote :

Greetings Bilal,

Thanks for the contribution! While there's nothing inherently wrong with this proposal @bilal, I'm wondering why you don't place your packages in an array and pass that to apt_install. Minor suggestion over-all.

Approved, +1 LGTM and merged / pushed upstream

review: Approve

« Back to merge proposal