Merge lp:~bbaqar/charms/trusty/plumgrid-edge/charmstore into lp:charms/trusty/plumgrid-edge

Proposed by Bilal Baqar on 2015-11-14
Status: Merged
Merged at revision: 14
Proposed branch: lp:~bbaqar/charms/trusty/plumgrid-edge/charmstore
Merge into: lp:charms/trusty/plumgrid-edge
Diff against target: 11 lines (+1/-0)
1 file modified
hooks/pg_edge_utils.py (+1/-0)
To merge this branch: bzr merge lp:~bbaqar/charms/trusty/plumgrid-edge/charmstore
Reviewer Review Type Date Requested Status
Charles Butler (community) 2015-11-14 Approve on 2015-12-10
Review Queue (community) automated testing Needs Fixing on 2015-11-15
Review via email: mp+277507@code.launchpad.net

Description of the change

dependecy of "cgroup-bin" package removed in 1:2015.1.2-0ubuntu1~cloud0 hence needs to be installed for plumgrid-lxc.

To post a comment you must log in.
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/1447/

review: Needs Fixing (automated testing)
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/1432/

review: Needs Fixing (automated testing)
Charles Butler (lazypower) wrote :

Greetings Bilal,

Thanks for the contribution! While there's nothing inherently wrong with this proposal @bilal, I'm wondering why you don't place your packages in an array and pass that to apt_install. Minor suggestion over-all.

Approved, +1 LGTM and merged / pushed upstream

review: Approve
Bilal Baqar (bbaqar) wrote :

I didnt know apt_install takes and array. I thought I would have to create a loop over an array thats why left it as is. I'll change it in the next MP.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/pg_edge_utils.py'
2--- hooks/pg_edge_utils.py 2015-08-24 16:22:15 +0000
3+++ hooks/pg_edge_utils.py 2015-11-14 22:21:33 +0000
4@@ -206,6 +206,7 @@
5 Disables Apparmor profile of libvirtd.
6 '''
7 apt_install('apparmor-utils')
8+ apt_install('cgroup-bin')
9 _exec_cmd(['sudo', 'aa-disable', '/usr/sbin/libvirtd'],
10 error_msg='Error disabling AppArmor profile of libvirtd')
11 disable_apparmor()

Subscribers

People subscribed via source and target branches

to all changes: