Code review comment for lp:~barry/window-mocker/py3

Revision history for this message
Barry Warsaw (barry) wrote :

Thanks Corey. Sorry for not seeing your mp first. I left a comment on yours:

https://code.launchpad.net/~coreygoldberg/window-mocker/py3/+merge/196978/comments/476977

tl;dr: window-mocker should be Python 3 only to eliminate the Python 2 dependencies. I'll leave the PyQt4/5 decisions to you guys, but it's pretty easy to switch between the two (I could make it easier yet by fiddling with the imports), as long as you don't need to speak both versions. Maybe supporting both makes transition easier?

« Back to merge proposal