Code review comment for lp:~coreygoldberg/window-mocker/py3
Revision history for this message
| Barry Warsaw (barry) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Apologies for not seeing this mp first, but I have a competing mp:
https:/
I'll take a look at Corey's branch and see if mine is missing anything. I don't have much of an opinion about PyQt4/PyQt5, but I have a strong opinion that window-mocker should only be Python 3. We don't want to B-D or Depend on any Python 2 related packages. Let's get rid of them once and for all. AFAICT, this is used as an application, not a library, so it doesn't need to be bilingual, and we definitely don't want to carry those extra dependencies. It also simplifies the code.
As for Qt4/5, what's the use case for letting that be switchable, other than the bug mentioned in my mp (which I can't reproduce here locally)? It should be hard to switch back to PyQt4, but OTOH PyQt5 works okay for me (and it passes all the tests <wink>). Does it need to be switchable, or can it be one or the other? OTOH, I don't care too much since both work in Python 3. :)