Code review comment for lp:~barcc/repeat-one-song/one-second-issue

Revision history for this message
Eduardo Mucelli Rezende Oliveira (eduardo-mucelli) wrote :

First of all, thanks for you effort to make this plugin better. My first approach when I started it was to call the do_previous with the same kind of "state machine" you did in the callback method on_song_change. Consequently, the erroneous behavior which happens when the user changes a song by himself happened to me, the same one that you pointed out -- and I totally agree with you about that there should be a way to differentiate its sources.

The last second cut off I guess is not a big deal, but I agree it is a problem. The play count can be fixed using rhythmdb, and I'd not realized until the moment, thanks again.

One awesome thing that the do_previous approach (I guess it) has, is the possibility to fix the crossfader problem reported by another user. I was wondering that last night.

Anyway, I'm really restricted about the time, and I will check everything out to answer your merge proposal.

Thanks B Clausius

« Back to merge proposal