Merge lp:~barcc/repeat-one-song/one-second-issue into lp:repeat-one-song/trunk
Proposed by
B. Clausius
Status: | Merged |
---|---|
Approved by: | Eduardo Mucelli Rezende Oliveira |
Approved revision: | 15 |
Merged at revision: | 16 |
Proposed branch: | lp:~barcc/repeat-one-song/one-second-issue |
Merge into: | lp:repeat-one-song/trunk |
Diff against target: |
122 lines (+43/-25) 1 file modified
__init__.py (+43/-25) |
To merge this branch: | bzr merge lp:~barcc/repeat-one-song/one-second-issue |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Eduardo Mucelli Rezende Oliveira | Approve | ||
B. Clausius (community) | Needs Fixing | ||
Review via email: mp+39285@code.launchpad.net |
Description of the change
This change solves this issues:
* last second from a song is cut off
* if the song duration is wrong (too long) the song is not repeated at all
* the play count is not incremented
Unfortunately this introduces another issue: If a song is playing and the user selects an other song, the plugin gets confused. Somehow in the playing-
To post a comment you must log in.
First of all, thanks for you effort to make this plugin better. My first approach when I started it was to call the do_previous with the same kind of "state machine" you did in the callback method on_song_change. Consequently, the erroneous behavior which happens when the user changes a song by himself happened to me, the same one that you pointed out -- and I totally agree with you about that there should be a way to differentiate its sources.
The last second cut off I guess is not a big deal, but I agree it is a problem. The play count can be fixed using rhythmdb, and I'd not realized until the moment, thanks again.
One awesome thing that the do_previous approach (I guess it) has, is the possibility to fix the crossfader problem reported by another user. I was wondering that last night.
Anyway, I'm really restricted about the time, and I will check everything out to answer your merge proposal.
Thanks B Clausius