Merge lp:~bac/launchpad/bug-436986-team-map into lp:launchpad
Proposed by
Brad Crittenden
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | not available | ||||
Proposed branch: | lp:~bac/launchpad/bug-436986-team-map | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
183 lines 6 files modified
lib/canonical/launchpad/javascript/lp/mapping.js (+1/-1) lib/lp/registry/browser/configure.zcml (+7/-1) lib/lp/registry/browser/team.py (+17/-9) lib/lp/registry/browser/tests/team-views.txt (+6/-6) lib/lp/registry/model/person.py (+2/-2) lib/lp/registry/stories/location/team-map.txt (+25/-0) |
||||
To merge this branch: | bzr merge lp:~bac/launchpad/bug-436986-team-map | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | Approve | ||
Review via email:
|
Commit message
Fix timeouts on the team index page caused by the bounds method not limiting data.
To post a comment you must log in.
= Summary =
The bounds method for the map portlet on the team index page times out as it uses all
participants to calculate the bounds. (Bug 436986)
== Proposed fix ==
1) Pass the limit to the model method that calculates the bounds.
2) Create new views for the portlet rather than relying on the ?preview parameter.
The ?preview happens only in the JS call but the view to calculate the bounds was
being used without preview and no limits.
== Pre-implementation notes ==
None
== Implementation details ==
As above.
== Tests ==
bin/test -vv -t team-views.txt -t team-map.txt
== Demo and Q/A ==
Create a huge team (e.g., big-team)and set the location for each member and then /launchpad. dev/~big- team. Verify that a subset of the members are shown
visit https:/
and the bounds are set appropriately for that subset.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: registry/ browser/ configure. zcml registry/ browser/ team.py /launchpad/ javascript/ lp/mapping. js registry/ browser/ tests/team- views.txt registry/ model/person. py registry/ stories/ location/ team-map. txt
lib/lp/
lib/lp/
lib/canonical
lib/lp/
lib/lp/
lib/lp/
== JSLint notices == bac/canonical/ lp-branches/bug-436986-team-map/ lib/canonical/ launchpad/ javascript/ bugs/bugtask- index.js' :
assignee_ picker. render( )
jslint: Lint found in
'/home/
Line 1382 character 33: Missing semicolon.
jslint: No problem found in bac/canonical/ lp-branches/bug-436986-team-map/ lib/canonical/ launchpad/ javascript/ lp/mapping. js'.
'/home/
jslint: 2 files to lint.
I'll fix this problem before landing.